Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi update #147

Merged
merged 48 commits into from
Jul 6, 2020
Merged

Openapi update #147

merged 48 commits into from
Jul 6, 2020

Conversation

swiftone
Copy link
Contributor

No description provided.

swiftone and others added 29 commits June 19, 2020 12:31
* test: add idp-crud it

* test: it for idp-user operations

* test: refactor idp-crub to use model methods

* refactor: remove commented code in idp-user

* test: it for idp-lifecycle

* test: add list social tokens test for idp-user

* test: it for idp-credential

* fix: remove only and counter

* test: add more assertions for key test suite
* test: add integration tests for sms template - OKTA-288648

* test: add comment and change test file name to map endpoints url

* test: fix async clean & move mock data to mocks folder

* chore(travis): run build before test

* Revert "chore(travis): run build before test"

This reverts commit b256985.
* test: it for policy-crud

* test: it for policy-lifecycle

* test: it for policy-rule
* test: it for user-linked-object

* test: it for applink

* test: it for user-client

* test: it for user-idp

* test: add and merge user lifecycle tests into user-lifecyle

* test: add missing lifecycle tests into user-lifecyle

* fix: idp test name

* test: add it for user grant

* fix: add assert to check if returned linked idp match with created idp
* fix: pass correct content type for publish csr - OKTA-288634
* test: add integration tests for event hook apis - OKTA-288645

* test: add doc link in comment
* test: add it for auth server

* fix: template generator to pass body to collection request
@shuowu-okta shuowu-okta marked this pull request as ready for review June 24, 2020 16:41
Copy link
Collaborator

@bretterer bretterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do some expansion on migration, but that should not be a blocker.

Our copyright should be 2017 - Present instead of an ending year.

README.md Outdated

The version 4.0 of this SDK dropped support for Node 8, which is EOL (End-of-Life) since 2019-12-31. Current supported minimum Node version is 10.0.0.

This version 4.0 release also updated APIs latest `@okta/openapi` (v2.0.0) that includes new endpoints and changed method names. Please see [CHANGELOG.md](CHANGELOG.md#400) for detailed information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to expand on this with how to handle some of the changes that were done. What you have now doesn't help guide the user through the changes, it just shows a diff

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -1,5 +1,5 @@
/*!
* Copyright (c) 2018-present, Okta, Inc. and/or its affiliates. All rights reserved.
* Copyright (c) 2018-2020present, Okta, Inc. and/or its affiliates. All rights reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2020 here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@shuowu
Copy link
Contributor

shuowu commented Jul 6, 2020

Our copyright should be 2017 - Present instead of an ending year.

This is a good catch, which means I need to re-generate all banners 👍

@shuowu shuowu requested a review from bretterer July 6, 2020 20:28
@shuowu
Copy link
Contributor

shuowu commented Jul 6, 2020

Looks like there is a script in the repo to always update banners to current year, I think we should be fine to use 2017-2020 here.

@shuowu-okta shuowu-okta merged commit 9241c78 into master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants