Openapi update #147
Merged
Openapi update #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: add idp-crud it * test: it for idp-user operations * test: refactor idp-crub to use model methods * refactor: remove commented code in idp-user * test: it for idp-lifecycle * test: add list social tokens test for idp-user * test: it for idp-credential * fix: remove only and counter * test: add more assertions for key test suite
* test: add integration tests for sms template - OKTA-288648 * test: add comment and change test file name to map endpoints url * test: fix async clean & move mock data to mocks folder * chore(travis): run build before test * Revert "chore(travis): run build before test" This reverts commit b256985.
* test: it for policy-crud * test: it for policy-lifecycle * test: it for policy-rule
* test: it for user-linked-object * test: it for applink * test: it for user-client * test: it for user-idp * test: add and merge user lifecycle tests into user-lifecyle * test: add missing lifecycle tests into user-lifecyle * fix: idp test name * test: add it for user grant * fix: add assert to check if returned linked idp match with created idp
* fix: pass correct content type for publish csr - OKTA-288634
* test: add integration tests for event hook apis - OKTA-288645 * test: add doc link in comment
* test: add it for auth server * fix: template generator to pass body to collection request
* doc: add changelog * doc: changelog fix * doc: update readme with changed method name Co-authored-by: Shuo Wu <wushuo2010@gmail.com>
shuowu-okta
requested review from
robertjd,
aarongranick-okta and
brettritter-okta
aarongranick-okta
approved these changes
Jun 29, 2020
bretterer
reviewed
Jul 6, 2020
README.md
Outdated
|
|
||
| The version 4.0 of this SDK dropped support for Node 8, which is EOL (End-of-Life) since 2019-12-31. Current supported minimum Node version is 10.0.0. | ||
|
|
||
| This version 4.0 release also updated APIs latest `@okta/openapi` (v2.0.0) that includes new endpoints and changed method names. Please see [CHANGELOG.md](CHANGELOG.md#400) for detailed information. |
There was a problem hiding this comment.
You may want to expand on this with how to handle some of the changes that were done. What you have now doesn't help guide the user through the changes, it just shows a diff
src/default-request-executor.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| /*! | |||
| * Copyright (c) 2018-present, Okta, Inc. and/or its affiliates. All rights reserved. | |||
| * Copyright (c) 2018-2020present, Okta, Inc. and/or its affiliates. All rights reserved. | |||
This is a good catch, which means I need to re-generate all banners 👍 |
|
Looks like there is a script in the repo to always update banners to current year, I think we should be fine to use 2017-2020 here. |
bretterer
approved these changes
Jul 6, 2020
aarongranick-okta
approved these changes
Jul 6, 2020
justinabrokwah-okta
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.