Integration tests for linked object api okta 288651 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu
changed the title
shuowu
changed the title
robertjd
approved these changes
May 21, 2020
test/it/linked-object.js
Outdated
| expect(linkedObject).to.be.instanceOf(models.LinkedObject); | ||
| }); | ||
|
|
||
| it('should match name from request', async () => { |
There was a problem hiding this comment.
Could these two it() be combined into one?
| expect(linkedObjectFromGet.primary.name).to.equal(mockLinkedObject.primary.name); | ||
| }); | ||
|
|
||
| it('should return LinkedObject by associated name', async () => { |
There was a problem hiding this comment.
Same question, can these it statements be combined?
There was a problem hiding this comment.
These two test cases match two different scenarios from D.O.C, I would prefer keeping them separate instead of adding comments. The tradeoff is it will take the total running time a bit longer...
shuowu-okta
force-pushed
the
sw-it-for-linked-object-api-OKTA-288651
branch
from
52be052
to
a01b6b5
Compare
shuowu-okta
pushed a commit
that referenced
this pull request
Jun 19, 2020
shuowu-okta
pushed a commit
that referenced
this pull request
Jul 6, 2020
* updates integration tests for new openapi * updates licensing banners * updated generated code * build from even updateder openapi * chore: sync with openapi master * fix: reference model data generation (#149) * chore: sync with openapi master * chore: sync with openapi master * chore: sync with openapi master * add integration tests for idp okta 288649 (#150) * test: add idp-crud it * test: it for idp-user operations * test: refactor idp-crub to use model methods * refactor: remove commented code in idp-user * test: it for idp-lifecycle * test: add list social tokens test for idp-user * test: it for idp-credential * fix: remove only and counter * test: add more assertions for key test suite * test: add it for user type api - OKTA-288654 (#153) * Integration tests for linked object api okta 288651 (#152) * test: add it for group api - OKTA-288652 (#154) * test: add integration tests for sms template - OKTA-288648 (#145) * test: add integration tests for sms template - OKTA-288648 * test: add comment and change test file name to map endpoints url * test: fix async clean & move mock data to mocks folder * chore(travis): run build before test * Revert "chore(travis): run build before test" This reverts commit b256985. * integration tests for policy api okta 288650 (#151) * test: it for policy-crud * test: it for policy-lifecycle * test: it for policy-rule * test: add it for user api - OKTA-288653 (#155) * test: it for user-linked-object * test: it for applink * test: it for user-client * test: it for user-idp * test: add and merge user lifecycle tests into user-lifecyle * test: add missing lifecycle tests into user-lifecyle * fix: idp test name * test: add it for user grant * fix: add assert to check if returned linked idp match with created idp * fix: support x-okta-multi-operation - OKTA-289242 (#156) * chore: sync with latest openapi master * chore: sync with openapi master * chore: sync with openapi master * fix: pass correct content type for publish csr - OKTA-288634 (#157) * fix: pass correct content type for publish csr - OKTA-288634 * test: add integration tests for event hook apis - OKTA-288645 (#164) * test: add integration tests for event hook apis - OKTA-288645 * test: add doc link in comment * test: add ITs for auth server - OKTA-288644 (#163) * test: add it for auth server * fix: template generator to pass body to collection request * test: enable skipped factor test - OKTA-288643 (#162) * test: skip csr test suites (#159) * test: add it for application - OKTA-288642 (#161) * chore: sync with latest openapi master * test: add integration tests for feature api - OKTA-288647 (#166) * test: add integration tests for inline hook api - OKTA-288646 (#165) * chore: sync with latest openapi * test: add it for admin role - OKTA-288641 (#158) * test: add it for admin role - OKTA-288641 * test: update test with openapi updates * chore: sync with latest openapi master * chore: drop support for node8 - OKTA-257574 (#167) * doc: add changelog - OKTA-305277 (#169) * doc: add changelog * doc: changelog fix * doc: update readme with changed method name * test: re-enable skipped key store tests * test: refactor mock data with faker (#170) * chore: sync with openapi master * chore: sync with openapi * chore: rename case sensitive files * test: fix link object fake names * test: use different user profiles on client-list-users test * chore: remove generated files before build (#172) * chore: update openapi version to latest in npm * doc: add migration guide Co-authored-by: Shuo Wu <wushuo2010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths covered in this PR: