Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toast): new component #279

Merged
merged 48 commits into from
Sep 6, 2023
Merged

Conversation

Cr0zy07
Copy link
Collaborator

@Cr0zy07 Cr0zy07 commented Aug 13, 2023

Description

Linked Issues

close #24

Additional context

Needs

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2023

Thank you for following the naming conventions! 🙏

@productdevbook
Copy link
Member

there was an update to the core see spelling in other components, if you apply similar spelling, you will work comfortably here

@productdevbook
Copy link
Member

dismissable-layer merged

@productdevbook productdevbook linked an issue Aug 28, 2023 that may be closed by this pull request
@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Aug 28, 2023

Hey @productdevbook, Could you please help me fix those errors and check if I applied the new changes correctly. TQ.

@productdevbook
Copy link
Member

Yes, I will check them all and make the necessary adjustments today.

@productdevbook
Copy link
Member

I'm done, can you check it out and start writing a storybook and test it, if you need help you can rewrite it. Thank you all code

@productdevbook
Copy link
Member

I think the problem is that the viewportRef inside the toast-viewport.ts is always null or might be something else.

I fixed this error, now there is another error.

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Sep 3, 2023

I think the problem is that the viewportRef inside the toast-viewport.ts is always null or might be something else.

I fixed this error, now there is another error.

Sorry, I was busy this weekend. I'm checking it now 😅>

BTW, thank you for your time and help.

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Sep 4, 2023

It still has some issues:

The Toast is not open by default. Although, the initialValue: true is set inside the useControllable.

One/Two issue/s might be related to slots.

And the scheduler flush issue, might be inside the utilis file.

I will try to fix them tonight...

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Sep 5, 2023

It still has some issues:

The Toast is not open by default. Although, the initialValue: true is set inside the useControllable.

One/Two issue/s might be related to slots.

And the scheduler flush issue, might be inside the utilis file.

I will try to fix them tonight...

Hey @productdevbook, could you please check it. All stories are working well expect the Styled and Chromatic.

For the Chromatic story, I still think that there is something wrong in the components slots!

@productdevbook
Copy link
Member

Now Fixed 🚀, Thank you so much for everything. You are great. You're doing great.

@productdevbook productdevbook marked this pull request as ready for review September 6, 2023 05:43
Copy link
Member

@productdevbook productdevbook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You best 👍

@productdevbook productdevbook merged commit 6d043aa into oku-ui:main Sep 6, 2023
6 checks passed
This was referenced Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast
2 participants