Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toast): story animation #352

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix(toast): story animation #352

merged 2 commits into from
Sep 12, 2023

Conversation

Cr0zy07
Copy link
Collaborator

@Cr0zy07 Cr0zy07 commented Sep 12, 2023

Description

Linked Issues

fix #279

Additional context

The Dialog component logs some warnings, and an aria-hidden error occurs when the Dialog closed.

@github-actions
Copy link
Contributor

Thank you for following the naming conventions! 🙏

productdevbook
productdevbook approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@productdevbook productdevbook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@productdevbook
Copy link
Member

The Dialog component logs some warnings, and an aria-hidden error occurs when the Dialog closed.

Can you open an issua for this so we can follow the issue.

@dammy001 dammy001 merged commit 2e37de3 into oku-ui:main Sep 12, 2023
6 checks passed
This was referenced Sep 12, 2023
Closed
Merged
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dammy001 dammy001 dammy001 approved these changes

@productdevbook productdevbook productdevbook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cr0zy07 @productdevbook @dammy001