Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tracing subscriber to 0.3 #18

Merged
merged 1 commit into from
Nov 7, 2021
Merged

update tracing subscriber to 0.3 #18

merged 1 commit into from
Nov 7, 2021

Conversation

mockersf
Copy link
Contributor

@mockersf mockersf commented Nov 6, 2021

update tracing-subscriber to the latest version

@mockersf mockersf mentioned this pull request Nov 6, 2021
Closed
@colelawrence
Copy link
Member

Acknowledged. We'll look towards publishing with this, this week. Thanks for your PR

colelawrence
colelawrence approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@colelawrence colelawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colelawrence colelawrence merged commit e50092a into old-storyai:master Nov 7, 2021
@colelawrence
Copy link
Member

Published as 0.2.1

@mockersf
Copy link
Contributor Author

mockersf commented Nov 7, 2021

Thanks for the quick merge!

Could you yank the 0.2.1 and republish as a 0.3.0? Changing the version of tracing-subscriber is a breaking change from Rust point of view, as you're using some of tracing-subscriber types in your exposed functions and they are not compatible between two versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colelawrence colelawrence colelawrence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @colelawrence