Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update tracing-subscriber requirement from 0.2.22 to 0.3.1 #3076

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Update tracing-subscriber requirement from 0.2.22 to 0.3.1 #3076

wants to merge 5 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Nov 6, 2021

Objective

Solution

  • A new feature need to be added to tracing-subscriber

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 6, 2021
@mockersf mockersf added C-Dependencies A change to the crates that Bevy depends on and removed S-Needs-Triage This issue needs to be labelled labels Nov 6, 2021
@mockersf
Copy link
Member Author

mockersf commented Nov 6, 2021

this still need to wait on tracing-wasm updating their dependency on tracing-subscriber: old-storyai/tracing-wasm#18

@colelawrence
Copy link

Updated tracing-wasm to 0.2.1. Please check.

@cart
Copy link
Member

cart commented Nov 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2021
@mockersf
Update tracing-subscriber requirement from 0.2.22 to 0.3.1 (#3076)
34f67f2 
# Objective

- Fix #3058 opened by dependabot

## Solution

- A new feature need to be added to `tracing-subscriber`
@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

Build failed:

@mockersf
Copy link
Member Author

simpler fix that should get something working now: #3102

@mockersf mockersf force-pushed the tracing-subscriber-0.3-update branch from 46e2527 to 85ea82c Compare November 11, 2021 11:16
@mockersf
Copy link
Member Author

mockersf commented Nov 11, 2021 •
edited
Loading

tracing-chrome updated thoren-d/tracing-chrome#4
tracing-tracy updated nagisa/rust_tracy_client#27

@mockersf
Copy link
Member Author

CI seems to say that all dependencies using tracing-subscriber are now updated 🎉

@cart
Copy link
Member

cart commented Nov 12, 2021

Brilliant! Lets give it a go!

@cart
Copy link
Member

cart commented Nov 12, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 12, 2021
@mockersf
Update tracing-subscriber requirement from 0.2.22 to 0.3.1 (#3076)
5127274 
# Objective

- Fix #3058 opened by dependabot

## Solution

- A new feature need to be added to `tracing-subscriber`
@bors
Copy link
Contributor

bors bot commented Nov 12, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update tracing-subscriber requirement from 0.2.22 to 0.3.1 [Merged by Bors] - Update tracing-subscriber requirement from 0.2.22 to 0.3.1 Nov 12, 2021
@bors bors bot closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @colelawrence @cart