Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for omero.logging properties #2433

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jun 26, 2024

See ome/openmicroscopy#6225

The first commit was created by the combination of ome/openmicroscopy#6393 and ome/omero-py#416 and adds the logging properties to the glossary

The second commit updates the developers logging page to reference the new properties and mention the configurability

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text reads fine and makes sense.

@jburel
Copy link
Member

jburel commented Jul 3, 2024

@sbesson
Copy link
Member Author

sbesson commented Jul 3, 2024

Changes to the configuration are made via https://github.com/ome/omero-documentation/blob/develop/omero/autogen_openmicroscopy.sh#L19

Yes that's the command I used together with the development builds of OMERO.py and OMERO.server including the PRs mentioned in the description to generate the new config.rst.

Main downside of the auto-generated strategy is that the current logic requires a full release of OMERO.server and/or OMERO.py to review the impact of a configuration addition/change in the documentation.

@jburel
Copy link
Member

jburel commented Jul 3, 2024

I agree that's why the synchronisation is failing due to changes in omero-common that have not been included in a release of openmicroscopy

@jburel jburel merged commit e6bda2d into ome:develop Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Document Python logging properties
3 participants