Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse omero.logging properties under new Logging heading #416

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jun 19, 2024

See ome/openmicroscopy#6393, this adds the corresponding changes to the omero config parse [--rst] command so that the properties gets properly parsed and included in a new section under https://omero.readthedocs.io/en/stable/sysadmins/config.html

To test these changes, a server binary needs to be built with the changes from ome/openmicroscopy#6393. Running OMERODIR=path_to_server omero config parse --rst should now include a Logging section with all omero.logging properties descriptions and their default values.

I expect that with the current 5.6.11 release of OMERO.server which does not includes these properties under etc/omero.properties, these additions should be a no-op and not impact the generated documentation.

@will-moore
Copy link
Member

Does this PR purely affect the omero config parse command (just for documentation/info) or does it have some other functional effect?

@sbesson
Copy link
Member Author

sbesson commented Jul 11, 2024

To the best of my knowledge, the only place where this codepath is used is the omero config parse command. It is certainly exclusively intended for documentation purposes.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jburel jburel merged commit 2891df1 into ome:master Jul 12, 2024
13 checks passed
@sbesson sbesson deleted the logging_config_parse branch July 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Document Python logging properties
4 participants