-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py2 #1
Py2 #1
Conversation
This is now getting to the point where I think I can try removing lib/python from an OMERO 5.5.1 installation and seeing if Unfortunately, users will need to https://github.com/ome/openmicroscopy/blob/develop/components/tools/OmeroPy/bin/omero#L77-L84 cc: @olatarkowska @manics @sbesson @will-moore |
Three (not necessarily mutually exclusive options) with various pros and cons are:
|
Changes to omero-server-docker for option 1 above:
Changes to omero-server-docker for option 2 above:
Additionally for option 2, I'd suggest we add:
but note that the referenced |
Since they all require an openmicroscopy release option 2 seems the cleanest |
Definitely agree that 2 is the cleanest, but I was hoping option 1 and option 2 didn't require an ome/openmicroscopy release. |
Note: one thing that can't be controlled is that if the user explicitly has set PYTHONPATH then that will be preferred. |
Summary:
|
General 👍 up: during the call. Only outstanding TODO is likely to strip out the integration tests and rebase, which I forgot to do. Otherwise, looking to get this pre-released to pypi (propose: |
Re-opening to kick off travis |
Merging and releasing this to PyPI now. Follow-up items include:
Other suggestions/ideas welcome either as a card on https://github.com/orgs/ome/projects/5 or as a new PR against this repository. |
Note: origin/master was force-pushed after this was merged since I forgot to run
|
As a minimal validation, I have been using the state of this repository within the context of IDR/idr-metadata#380 (comment):
Everything worked as expected with the projects and datasets being annotated as expected using the pip-installed library |
Does that imply we should go ahead and tag 5.5.1? cc: @ome/python |
This should replace the wait.sh-stype scripts that exist in multiple (especially docker) repositories. Example output: ``` $ omero sessions login -w omero root@localhost --retry=100 Previous session expired for root on localhost:4064 09:41:30.959913: Login retry ome#1 in 3s 09:41:33.977181: Login retry ome#2 in 3s ... 09:41:58.129038: Login retry ome#10 in 3s WARNING:omero.client:None - createSession retry: 1 WARNING:omero.client:None - createSession retry: 2 09:42:17.100098: Login retry ome#11 in 3s Created session for root@localhost:4064. Idle timeout: 10 min. Current group: system ```` see: https://github.com/ome/omero-server-docker/blob/master/test_login.sh
Show Image, Dataset and Project in a table
This PR intends to add the necessary infrastructure on top of a decoupled versions of https://github.com/ome/openmicroscopy/releases/tag/v5.5.1 (c21d65e) such that
python setup.py
leads to a package that can then bepip
-installed.