-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests #10
Fix unit tests #10
Conversation
If OMERODIR is set, we can read omero.properties and most tests are run except those that need omero.db.version. If OMERODIR is not set, only 3 tests are run
Travis fails with
|
src/omero/cli.py
Outdated
@@ -718,7 +718,8 @@ def add_error(self, name, rcode, msg): | |||
""" | |||
err = self.__errors.get(name) | |||
if err is not None: | |||
self.ctx.die(2, "Error already exists: %s (%s)" % (name, err)) | |||
# self.ctx.die(, "Error already exists: %s (%s)" % (name, err)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just be careful with this one ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops - I commented that out to get tests passing locally but am not sure why it's failing or what use case it's expected to handle?
Seems tests aren't actually being run:
|
Hmmm - I thought the my "fix" at d0ec9b7 got Travis green, but it seems that what's changed is using
|
Since we don't have scripts available for unit tests now
@@ -183,16 +181,16 @@ def testGroupingWithMainExtraDot(self): | |||
assert "belong" == groupings["A"]["2"], str(groupings) | |||
assert "together" == groupings["A"]["3"], str(groupings) | |||
|
|||
def testParseAllOfficialScripts(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be migrated to scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``` E ImportError: libssl.so.10: cannot open shared object file: No such file or directory ``` Once multiple environments need running, this may have to be reverted.
Merging so that other PRs will start getting the benefit of the tests. Thanks, @will-moore ! |
omero-py 5.8.1
This should replace the wait.sh-stype scripts that exist in multiple (especially docker) repositories. Example output: ``` $ omero sessions login -w omero root@localhost --retry=100 Previous session expired for root on localhost:4064 09:41:30.959913: Login retry ome#1 in 3s 09:41:33.977181: Login retry ome#2 in 3s ... 09:41:58.129038: Login retry ome#10 in 3s WARNING:omero.client:None - createSession retry: 1 WARNING:omero.client:None - createSession retry: 2 09:42:17.100098: Login retry ome#11 in 3s Created session for root@localhost:4064. Idle timeout: 10 min. Current group: system ```` see: https://github.com/ome/omero-server-docker/blob/master/test_login.sh
Work in progress...
Teaching tests to skip if they need
OMERODIR
to run and it isn't set.Or to skip permanently if they need
omero.db.version
etc frometc/properties
since this is no-longer stored there.TODO:
omero-web
scripts