Fix unit tests #10
Merged
Fix unit tests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If OMERODIR is set, we can read omero.properties and most tests are run except those that need omero.db.version. If OMERODIR is not set, only 3 tests are run
|
Travis fails with |
joshmoore
reviewed
Aug 29, 2019
src/omero/cli.py
Outdated
| @@ -718,7 +718,8 @@ def add_error(self, name, rcode, msg): | |||
| """ | |||
| err = self.__errors.get(name) | |||
| if err is not None: | |||
| self.ctx.die(2, "Error already exists: %s (%s)" % (name, err)) | |||
| # self.ctx.die(, "Error already exists: %s (%s)" % (name, err)) | |||
There was a problem hiding this comment.
Just be careful with this one ;)
There was a problem hiding this comment.
Ooops - I commented that out to get tests passing locally but am not sure why it's failing or what use case it's expected to handle?
|
Seems tests aren't actually being run: |
|
Hmmm - I thought the my "fix" at d0ec9b7 got Travis green, but it seems that what's changed is using |
Since we don't have scripts available for unit tests now
joshmoore
reviewed
Aug 30, 2019
| @@ -183,16 +181,16 @@ def testGroupingWithMainExtraDot(self): | |||
| assert "belong" == groupings["A"]["2"], str(groupings) | |||
| assert "together" == groupings["A"]["3"], str(groupings) | |||
|
|
|||
| def testParseAllOfficialScripts(self): | |||
There was a problem hiding this comment.
This should be migrated to scripts.
```
E ImportError: libssl.so.10: cannot open shared object file:
No such file or directory
```
Once multiple environments need running, this may have to be reverted.
Merging so that other PRs will start getting the benefit of the tests. Thanks, @will-moore ! |
joshmoore
added a commit
to joshmoore/omero-scripts
that referenced
this pull request
Sep 2, 2019
joshmoore
added a commit
to joshmoore/omero-scripts
that referenced
this pull request
Sep 2, 2019
sbesson
added a commit
to sbesson/omero-py
that referenced
this pull request
Oct 5, 2020
omero-py 5.8.1
snoopycrimecop
pushed a commit
to snoopycrimecop/omero-py
that referenced
this pull request
Apr 1, 2021
This should replace the wait.sh-stype scripts that exist in
multiple (especially docker) repositories.
Example output:
```
$ omero sessions login -w omero root@localhost --retry=100
Previous session expired for root on localhost:4064
09:41:30.959913: Login retry ome#1 in 3s
09:41:33.977181: Login retry ome#2 in 3s
...
09:41:58.129038: Login retry ome#10 in 3s
WARNING:omero.client:None - createSession retry: 1
WARNING:omero.client:None - createSession retry: 2
09:42:17.100098: Login retry ome#11 in 3s
Created session for root@localhost:4064. Idle timeout: 10 min. Current group: system
````
see: https://github.com/ome/omero-server-docker/blob/master/test_login.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress...
Teaching tests to skip if they need
OMERODIRto run and it isn't set.Or to skip permanently if they need
omero.db.versionetc frometc/propertiessince this is no-longer stored there.TODO:
omero-webscripts