-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move path.py to omero_ext #123
Conversation
Immediate thought is that the impact of this change might be fairly large since only in OME, multiple downstream Python components depend on this import. On the other hand, having the My vote goes toward investing into the namespacing effort. Other potential candidates to review might be |
Re-included though ome/omero-scripts#160 will need fixing before we merge (otherwise script PRs will start failing) |
I think all PRs are now open that would allow this PR to be un-excluded, but waiting on ome/omero-scripts#160 to go green. cc: @will-moore @sbesson |
From my side with 5.6.0-m2 behind us, no objection to seeing this unexcluded. |
Conflicting PR. Removed from build OMERO-python-superbuild-push#79. See the console output for more details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above, I am in favor of getting this PR merged together with all companion PRs which are implementing a backwards compatible way to deal with the import renaming. This is effectively a breaking change which will need to be documented appropriately in the changelog of this repository. However, due to the interference with upstream path
in conda environment, this is largely unavoidable.
Moving forward we will want to review whether switching to the upstream path
module is a possibility when time allows.
Merging and tagging as 5.6.dev6 |
fix #117