-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated CLI plugins #124
Conversation
As suggested by ome/openmicroscopy#6183, the main breaking change associated with this proposal (or the alternate class removal) is that |
With |
I also still get the deprecation warning. Maybe I'm missing something...
|
You are correct, both deprecated plugins should display the same message to end users, I will look into adding some message.
That's related to #123. The same exception handling as in ome/omero-dropbox#8 will need to be opened against |
All working exactly as described in the description. 👍 |
Thanks, all. |
Fixes #22 - see #23 for the previous attempt and #123 for a similar issue.
c81c3e6 ensures the plugins under
omero/plugins
are sorted before being loaded and registered as controls. 9160a88 renames theupload
andmetadata
plugins as_upload_deprecated.py
and_metadata_deprecated.py
. This renaming should ensure the plugins are always loaded and registered first so that they can be overriden by anotherregister_only
call if the decoupledomero-metadata
andomero-upload
libraries are also installed.This PR should be tested in a virtualenvironment in two steps
omero-py
alone with no plugins installedomero-py
with plugins installed