Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing a non-trivially-copyable comparator to sort #1932

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Allow passing a non-trivially-copyable comparator to sort #1932

merged 3 commits into from
Nov 6, 2024

Conversation

dmitriy-sobolev
Copy link
Contributor

Fixes #1924.

@dmitriy-sobolev
Allow passing a device-copyable comparator to sort
71fe89c 
Signed-off-by: Dmitriy Sobolev <dmitriy.sobolev@intel.com>
danhoeflinger
danhoeflinger previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should fix the issue.
Thanks

We really need to push for the change to SYCL to make this sort of type intrinsically device copyable. Its a really frustrating maintenance problem.

Edit: added a comment which should be addressed before merging, in my opinion.

@danhoeflinger danhoeflinger self-requested a review November 4, 2024 20:48
@danhoeflinger danhoeflinger dismissed their stale review November 4, 2024 20:58

found something which needs addressing

@dmitriy-sobolev
Add sycl_traits.h
1fa7438 
Signed-off-by: Dmitriy Sobolev <dmitriy.sobolev@intel.com>
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/sort-leaf-device branch from b4b5ecf to 1fa7438 Compare November 5, 2024 13:50
danhoeflinger
danhoeflinger previously approved these changes Nov 5, 2024
View reviewed changes
@dmitriy-sobolev
More comments for device_copyable test
af9577c 
Signed-off-by: Dmitriy Sobolev <dmitriy.sobolev@intel.com>
@dmitriy-sobolev dmitriy-sobolev merged commit a037165 into main Nov 6, 2024
22 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/sort-leaf-device branch November 6, 2024 13:11
@dmitriy-sobolev dmitriy-sobolev mentioned this pull request Nov 6, 2024
Closed
@dmitriy-sobolev dmitriy-sobolev mentioned this pull request Nov 13, 2024
Merged
@masterleinad masterleinad mentioned this pull request Nov 19, 2024
Draft
@masterleinad
Copy link
Contributor

Will this also make it into the 2022.7.1 patch release?

@dmitriy-sobolev
Copy link
Contributor Author

dmitriy-sobolev commented Nov 20, 2024 •
edited
Loading

@timmiesmith, could you make sure this is a part of 2022.7.1 as well (together with #1927)?

@timmiesmith
Copy link
Contributor

@dmitriy-sobolev @masterleinad I will include it in the patch release.

timmiesmith pushed a commit that referenced this pull request Nov 20, 2024
@dmitriy-sobolev @timmiesmith
Allow passing a non-trivially-copyable comparator to sort (#1932)
7011c7f 
Signed-off-by: Dmitriy Sobolev <dmitriy.sobolev@intel.com>
timmiesmith added a commit that referenced this pull request Nov 20, 2024
@timmiesmith @dmitriy-sobolev
Cherry pick #1932 to release branch (#1943)
969c5e8 
Signed-off-by: Dmitriy Sobolev <dmitriy.sobolev@intel.com>
Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>
@masterleinad masterleinad mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhoeflinger danhoeflinger danhoeflinger approved these changes

@MikeDvorskiy MikeDvorskiy Awaiting requested review from MikeDvorskiy

@adamfidel adamfidel Awaiting requested review from adamfidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non-trivially-copyable comparators aren't supported for sort/sort_by_key
4 participants
@dmitriy-sobolev @masterleinad @timmiesmith @danhoeflinger