Fix crash in urAdapterGet with non-initialized platforms #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Dec 13, 2023
There was a problem hiding this comment.
I don't think the fix is this simple. If there's only one adapter, we might never get into the loader's urAdapterGet implementation. But this is a step in the right direction.
Eventually, we might want to rewrite the way adapters are initialized, so that it's possible to just not have the broken adapters in the platforms collection.
pbalcer
approved these changes
Jan 11, 2024
al42and
force-pushed
the
fix-uninit-platforms
branch
from
316eea4
to
51fa83e
Compare
kbenzie
added
loader
Encountered in a bothched ASAN build, but makes sense to check platform status before trying to query it.
kbenzie
force-pushed
the
fix-uninit-platforms
branch
from
51fa83e
to
200e628
Compare
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered in a bothched ASAN build, but makes sense to check platform status before trying to query it.