Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix tests for React 15 #135

Merged
merged 9 commits into from
Jul 4, 2016

Conversation

thathenderson
Copy link

@thathenderson thathenderson commented Apr 21, 2016

This updates peerDependencies after the changes in a50d53c, fixes a few nits in the example code, fixes a reference to renderToString() in the gulpfile, and updates the following things in a handful of tests:

  • fixes references to unmountComponentAtNode()
  • replaced all usage of getDOMNode() with ReactDOM.findDOMNode()
  • fixes a DOM render warning about rendering td inside tbody

After these updates, there were no console warnings in develop mode, and all tests pass:
screen shot 2016-04-21 at 12 03 05 pm

Let me know if the peerDependency semver range needs to change: I did 15.x.x because that seemed to emulate the expected range. Previously, since we were using ^0.14.0, and (I think) React was pushing minor and patches on the last digit, we would have gotten both. However, I'm up for whatever you guys think is best!

@thathenderson
Copy link
Author

Any chance we could get this merged soon, @AlanFoster?

@thathenderson
Copy link
Author

Bumping. Do you have a few minutes to take a peek @AlanFoster?

@ratson
Copy link

ratson commented May 4, 2016

@AlanFoster React v15 has been released about a month and 2 patch releases were out, it should be stable enough to add support for it.

@thathenderson
Copy link
Author

thathenderson commented May 16, 2016

One more bump. Any project owners that could get this merged? I think React 15 support is something we would all like.

@jkimbo @AndrewIngram

@fluse
Copy link

fluse commented May 19, 2016

@AlanFoster please merge branches!!!!!!!

@wmertens
Copy link
Contributor

@AlanFoster I verified this PR and it works great. The only change is that npm doesn't complain any more in projects using react-daterange-picker. It is safe to merge 👍.

@AlanFoster
Copy link
Member

@thathenderson @wmertens Thanks guys; Will try to get this in ASAP! 👍

@AlanFoster
Copy link
Member

@thathenderson Thanks for the great work 👍

@AlanFoster AlanFoster merged commit ccdaaba into onefinestay:master Jul 4, 2016
@ovidiuch
Copy link

ovidiuch commented Jul 5, 2016

@AlanFoster any plans to bump the pkg version and publish updates to npm? Looking forward to using it with React 15. Thanks.

@michaeljonsampson michaeljonsampson mentioned this pull request Jul 11, 2016
@AlanFoster
Copy link
Member

Thanks for the great work @thathenderson

This should now be available on npm as version v1.1.0 - let me know if there are any issues 👍

@thathenderson
Copy link
Author

Will do, thanks for the merge @AlanFoster 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants