-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and fix tests for React 15 #135
Update dependencies and fix tests for React 15 #135
Conversation
…x and 15.x.x, Updating react-addons-* in dependencies and devDependencies to work with both 0.14.x and 15.x.x
…ge-picker into update-for-react-15
Fixing reference to unmountComponentAtNode (now permanently on ReactDOM).
…OM). Replacing getDOMNode() usage with ReactDOM.findDOMNode().
Any chance we could get this merged soon, @AlanFoster? |
Bumping. Do you have a few minutes to take a peek @AlanFoster? |
@AlanFoster React v15 has been released about a month and 2 patch releases were out, it should be stable enough to add support for it. |
One more bump. Any project owners that could get this merged? I think React 15 support is something we would all like. |
@AlanFoster please merge branches!!!!!!! |
@AlanFoster I verified this PR and it works great. The only change is that npm doesn't complain any more in projects using react-daterange-picker. It is safe to merge 👍. |
@thathenderson @wmertens Thanks guys; Will try to get this in ASAP! 👍 |
@thathenderson Thanks for the great work 👍 |
@AlanFoster any plans to bump the pkg version and publish updates to npm? Looking forward to using it with React 15. Thanks. |
Thanks for the great work @thathenderson This should now be available on |
Will do, thanks for the merge @AlanFoster 👍 |
This updates peerDependencies after the changes in a50d53c, fixes a few nits in the example code, fixes a reference to renderToString() in the gulpfile, and updates the following things in a handful of tests:
After these updates, there were no console warnings in develop mode, and all tests pass:
Let me know if the peerDependency semver range needs to change: I did 15.x.x because that seemed to emulate the expected range. Previously, since we were using ^0.14.0, and (I think) React was pushing minor and patches on the last digit, we would have gotten both. However, I'm up for whatever you guys think is best!