Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix tests for React 15 #135

Merged
merged 9 commits into from
Jul 4, 2016
8 changes: 4 additions & 4 deletions example/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ const DatePickerRange = React.createClass({
<RangePicker {...this.props} onSelect={this.handleSelect} value={this.state.value} />
<div>
<input type="text"
value={this.state.value ? this.state.value.start.format('LL') : null}
value={this.state.value ? this.state.value.start.format('LL') : ""}
readOnly={true}
placeholder="Start date"/>
<input type="text"
value={this.state.value ? this.state.value.end.format('LL') : null}
value={this.state.value ? this.state.value.end.format('LL') : ""}
readOnly={true}
placeholder="End date" />
</div>
Expand All @@ -64,7 +64,7 @@ const DatePickerRange = React.createClass({
const DatePickerSingle = React.createClass({
getInitialState() {
return {
value: null,
value: "",
};
},

Expand All @@ -81,7 +81,7 @@ const DatePickerSingle = React.createClass({
value={this.state.value} />
<div>
<input type="text"
value={this.state.value ? this.state.value.format('LL') : null}
value={this.state.value ? this.state.value.format('LL') : ""}
readOnly={true} />
</div>
</div>
Expand Down
3 changes: 2 additions & 1 deletion gulpfile.babel.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import gulp from 'gulp';

import gulpLoadPlugins from 'gulp-load-plugins';
import React from 'react';
import ReactDOMServer from 'react-dom/server';
import webpack from 'webpack';
import { Server as KarmaServer } from 'karma';
import clean from 'del';
Expand Down Expand Up @@ -155,7 +156,7 @@ gulp.task('build-example', function() {
});

var Index = React.createFactory(require('./example/base.jsx'));
var markup = '<!document html>' + React.renderToString(Index());
var markup = '<!document html>' + ReactDOMServer.renderToString(Index());

// write file
fs.writeFileSync('./example/index.html', markup);
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,16 @@
"url": "https://github.com/onefinestay/react-daterange-picker"
},
"peerDependencies": {
"react": "^0.14.0",
"react-dom": "^0.14.0"
"react": "^0.14.0 || 15.x.x",
"react-dom": "^0.14.0 || 15.x.x"
},
"dependencies": {
"calendar": "^0.1.0",
"classnames": "^2.1.1",
"immutable": "^3.7.2",
"moment": "^2.10.6",
"moment-range": "^2.0.3",
"react-addons-pure-render-mixin": "^0.14.0"
"react-addons-pure-render-mixin": "^0.14.0 || 15.x.x"
},
"devDependencies": {
"babel": "^5.2.16",
Expand Down Expand Up @@ -89,7 +89,7 @@
"object.assign": "^1.1.1",
"phantomjs": "^1.9.18",
"run-sequence": "~1.1.4",
"react-addons-test-utils": "^0.14.0",
"react-addons-test-utils": "^0.14.0 || 15.x.x",
"timekeeper": "0.0.5",
"transform-loader": "^0.2.1",
"underscore": "^1.8.3",
Expand Down
11 changes: 7 additions & 4 deletions src/calendar/tests/CalendarDate.spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
import ReactDOM from 'react-dom';
import TestUtils from 'react-addons-test-utils';
import moment from 'moment';
import _ from 'underscore';
Expand Down Expand Up @@ -59,9 +60,11 @@ describe('The CalendarDate Component', function () {
};

this.useDocumentRenderer = (props) => {
const renderedTable = TestUtils.renderIntoDocument(<table>
<tbody>{getCalendarDate(props)}</tbody>
</table>);
const renderedTable = TestUtils.renderIntoDocument(
<table>
<tbody><tr>{getCalendarDate(props)}</tr></tbody>
</table>
);
this.renderedComponent = renderedTable.querySelector('td');
};

Expand All @@ -72,7 +75,7 @@ describe('The CalendarDate Component', function () {

afterEach( function () {
if (this.component) {
React.unmountComponentAtNode(React.findDOMNode(this.component).parentNode);
ReactDOM.unmountComponentAtNode(ReactDOM.findDOMNode(this.component).parentNode);
}
});

Expand Down
15 changes: 8 additions & 7 deletions src/calendar/tests/CalendarMonth.spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
import ReactDOM from 'react-dom';
import TestUtils from 'react-addons-test-utils';
import CalendarMonth from '../CalendarMonth';
import CalendarDate from '../CalendarDate';
Expand Down Expand Up @@ -58,7 +59,7 @@ describe('The CalendarMonth Component', function () {

afterEach( function () {
if (this.component) {
React.unmountComponentAtNode(React.findDOMNode(this.component).parentNode);
ReactDOM.unmountComponentAtNode(ReactDOM.findDOMNode(this.component).parentNode);
}
});

Expand Down Expand Up @@ -115,12 +116,12 @@ describe('The CalendarMonth Component', function () {

it('which calls props.onMonthChange if props.disableNavigation is false and if the selected value changes', function () {
var onMonthChange = jasmine.createSpy();
this.useDocumentRenderer({
onMonthChange: onMonthChange,
});
var select = TestUtils.scryRenderedDOMComponentsWithTag(this.renderedComponent, 'select')[0].getDOMNode();
select.value = '2';
this.useDocumentRenderer({ onMonthChange: onMonthChange });

var select = TestUtils.scryRenderedDOMComponentsWithTag(this.renderedComponent, 'select')[0];
select.value = 2;
TestUtils.Simulate.change(select);

expect(onMonthChange).toHaveBeenCalledWith(2);
});

Expand Down Expand Up @@ -165,7 +166,7 @@ describe('The CalendarMonth Component', function () {
this.useDocumentRenderer({
onYearChange: onYearChange,
});
var select = TestUtils.scryRenderedDOMComponentsWithTag(this.renderedComponent, 'select')[1].getDOMNode();
var select = TestUtils.scryRenderedDOMComponentsWithTag(this.renderedComponent, 'select')[1];
var value = (this.firstOfMonth.year() + 1).toString();
select.value = value;
TestUtils.Simulate.change(select);
Expand Down
3 changes: 2 additions & 1 deletion src/tests/DateRangePicker.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import isMomentRange from '../utils/isMomentRange';
import areMomentRangesEqual from '../utils/areMomentRangesEqual';
import Immutable from 'immutable';
import React from 'react';
import ReactDOM from 'react-dom';
import TestUtils from 'react-addons-test-utils';
import _ from 'underscore';

Expand Down Expand Up @@ -75,7 +76,7 @@ describe('The DateRangePicker component', function () {

afterEach( function () {
if (this.component) {
React.unmountComponentAtNode(React.findDOMNode(this.component).parentNode);
ReactDOM.unmountComponentAtNode(ReactDOM.findDOMNode(this.component).parentNode);
}
});

Expand Down
3 changes: 2 additions & 1 deletion src/tests/Legend.spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
import ReactDOM from 'react-dom';
import TestUtils from 'react-addons-test-utils';
import Legend from '../Legend';
import _ from 'underscore';
Expand Down Expand Up @@ -32,7 +33,7 @@ describe('The Legend component', function () {

afterEach( function () {
if (this.component) {
React.unmountComponentAtNode(React.findDOMNode(this.component).parentNode);
ReactDOM.unmountComponentAtNode(ReactDOM.findDOMNode(this.component).parentNode);
}
});

Expand Down