Skip to content

Commit

Permalink
fix(core): correct "disabled" styling for checkbox and radio (#328)
Browse files Browse the repository at this point in the history
  • Loading branch information
josokinas authored Feb 17, 2021
1 parent 68aab8a commit a68dc30
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 5 deletions.
10 changes: 8 additions & 2 deletions packages/core/src/components/checkbox/checkbox.scss
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@
}

// indicating [disabled] input
.ods-checkbox:disabled + .ods-input-indicator::after {
border-color: helpers.color('content-disabled');
.ods-checkbox:disabled + .ods-input-indicator {
&::after {
border-color: helpers.color('content-disabled');
}

&::before {
background-color: helpers.color('background-disabled');
}
}
}
10 changes: 8 additions & 2 deletions packages/core/src/components/radio/radio.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,13 @@
}

// indicating [disabled] input
.ods-radio:disabled + .ods-input-indicator::after {
background-color: helpers.color('content-disabled');
.ods-radio:disabled + .ods-input-indicator {
&::after {
background-color: helpers.color('content-disabled');
}

&::before {
background-color: helpers.color('background-disabled');
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@
.ods-checkbox:disabled,
.ods-radio:disabled {
+ .ods-input-indicator::before {
background-color: helpers.color('background-disabled');
border-color: helpers.color('border-disabled');
}

Expand Down

0 comments on commit a68dc30

Please sign in to comment.