Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): correct "disabled" styling for checkbox and radio #328

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fix(core): correct "disabled" styling for checkbox and radio #328

merged 1 commit into from
Feb 17, 2021

Conversation

josokinas
Copy link
Contributor

Purpose

Checkbox within "checked" and also "disabled" state has wrong styling:

image

Approach

  • correctly styling "disabled" checkbox state via "after" and "before" pseudo selectors
  • move background color change for "disabled" indicator container to "radio" (as this is only needed by it)

Testing

On Storybook.

Risks

N/A

@josokinas josokinas added this to the 1.1.0 milestone Feb 17, 2021
@josokinas josokinas requested a review from rabelloo February 17, 2021 14:28
@josokinas josokinas self-assigned this Feb 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2021 •
edited
Loading

🎊 PR Preview 99e92a4 has been successfully built and deployed to https://onfido-castor-preview-pr-328.surge.sh

🕐 Build time: 111.437s

🤖 By surge-preview

@rabelloo
Copy link
Contributor

LGTM

@josokinas josokinas merged commit a68dc30 into main Feb 17, 2021
@josokinas josokinas deleted the fix/disabled-checkbox-and-radio branch February 17, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabelloo rabelloo rabelloo approved these changes

Assignees

@josokinas josokinas

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@josokinas @rabelloo