Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: add ods- prefix to all tokens #103

Merged
merged 3 commits into from
Dec 17, 2020
Merged

feat(core)!: add ods- prefix to all tokens #103

merged 3 commits into from
Dec 17, 2020

Conversation

rabelloo
Copy link
Contributor

@rabelloo rabelloo commented Dec 14, 2020

Purpose

closes #102

Approach

Search and replace.

Testing

Local.

Risks

Breaking change introduced.

@rabelloo rabelloo requested a review from josokinas December 14, 2020 13:26
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2020

🎊 PR Preview 013b51c has been successfully built and deployed to https://onfido-castor-preview-pr-103.surge.sh

🕐 Build time: 107.654s

🤖 By surge-preview

@josokinas
Copy link
Contributor

josokinas commented Dec 14, 2020

There's a diff of alphabetical sort order of imports in this PR. Would you mind to open a separate PR first, go through each file and save them so that it's all sorted and future code changes would not include it? It's just that it (Git history) would be cleaner that way...

Same goes to doc change - having it merged as a separate PR would be nicer 😏

@rabelloo
Copy link
Contributor Author

rabelloo commented Dec 14, 2020

Sure thing, let me open separate PRs for those, then we can rebase this on top of that.

#104
#105

@rabelloo rabelloo force-pushed the feat/ods-prefix branch 2 times, most recently from 35f6507 to 1f89bb9 Compare December 15, 2020 10:22
packages/core/src/theme/themes/day.scss Outdated Show resolved Hide resolved
@josokinas josokinas added this to the 1.0.0 milestone Dec 16, 2020
@rabelloo rabelloo merged commit 0fec645 into main Dec 17, 2020
@rabelloo rabelloo deleted the feat/ods-prefix branch December 17, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix tokens
2 participants