Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint import order #104

Merged
merged 2 commits into from
Dec 15, 2020
Merged

chore: lint import order #104

merged 2 commits into from
Dec 15, 2020

Conversation

rabelloo
Copy link
Contributor

Purpose

Standardise import/export order.

Approach

Use VSCode's "Organize Imports" feature on every file.

Testing

Local.

Risks

  • Yet no automated CI way to enforce import/export order in the future;
  • Since it auto-organises exports as well, some .stories.tsx would have their order changed, so I had to update code a bit to organised imports and arbitrarily sorted exports.

@rabelloo rabelloo requested a review from josokinas December 14, 2020 17:04
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2020

🎊 PR Preview badb74f has been successfully built and deployed to https://onfido-castor-preview-pr-104.surge.sh

🕐 Build time: 119.414s

🤖 By surge-preview

@rabelloo rabelloo merged commit 5cc669f into main Dec 15, 2020
@rabelloo rabelloo deleted the chore/import-order branch December 15, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants