Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add select (custom) component #965

Merged
merged 24 commits into from
Oct 14, 2021
Merged

feat!: add select (custom) component #965

merged 24 commits into from
Oct 14, 2021

Conversation

rabelloo
Copy link
Contributor

@rabelloo rabelloo commented Sep 8, 2021

Purpose

Implement non-native Select component.

closes #3

Approach

Reuse Popover for placement techniques, reuse native Select for styling.
Add hooks and conditional logic as React component entry point.

Testing

Preview.

Risks

Changes native Select and Popover styles a bit, but should be retro compatible.

@rabelloo rabelloo added the component Implement or enhance a component label Sep 8, 2021
@rabelloo rabelloo requested a review from josokinas September 8, 2021 09:24
@rabelloo rabelloo self-assigned this Sep 8, 2021
@vercel
Copy link

vercel bot commented Sep 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onfido-oss/castor/Ge2H94QHMR6ZpndEihUAUivqR9iN
✅ Preview: https://castor-git-feat-select-alt-onfido-oss.vercel.app

Base automatically changed from feat/popover to main September 14, 2021 09:03
@josokinas josokinas mentioned this pull request Sep 16, 2021
Closed
rabelloo added 23 commits October 14, 2021 17:57
@rabelloo
feat: add select (custom) component
8d78435
@rabelloo
fix: disallow "placeholder" as prop
bc5459a
@rabelloo
style: accept suggestion
bd7e84d
@rabelloo
refactor: rename register to initialize
507e5fb
@rabelloo
style: restProps
f3c8a38
@rabelloo
refactor: hoist logic from native select
adebeaf
@rabelloo
fix: omit Select's Popover content from Field
d7def3e
@rabelloo
fix: disabled options don't show an active state
a391c8e
@rabelloo
fix: selected but disabled options don't show icon
a11502b
@rabelloo
fix: exposed properties in CustomSelect
51411b4
@rabelloo
docs: improve options
0b39813
@rabelloo
style: reorder
7bea188
@rabelloo
docs: disable placeholder option
e274d31
@rabelloo
style: variable rename
425b057
@rabelloo
fix: only focus :enabled Options
511d986
@rabelloo
fix: don't set value, it'll infer from option
3339491
@rabelloo
fix: don't blur when the Popover is open
a20e551
@rabelloo
fix: onClick instead of onMouseUp
da33557 
prevents "drag clicks" between options
@rabelloo
fix: bubble onChange
fc29569
@rabelloo
docs: improve stories
af56a4f
@rabelloo
docs: start migration guide
c212e73
@rabelloo
revert: variable rename
8464834
@rabelloo
fix: popover overlay is visible
5efdb47
@rabelloo rabelloo merged commit f566ca9 into main Oct 14, 2021
@rabelloo rabelloo deleted the feat/select-alt branch October 14, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josokinas josokinas josokinas approved these changes

Assignees

@rabelloo rabelloo

Labels
component Implement or enhance a component
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Select
2 participants
@rabelloo @josokinas