Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add select (custom) component #965

Merged
merged 24 commits into from
Oct 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .bundlewatchrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
"files": [
{
"path": "./packages/core/dist/castor.css",
"maxSize": "5KB"
"maxSize": "8KB"
},
{
"path": "./packages/*/prototype.js",
"maxSize": "60KB"
"maxSize": "70KB"
}
]
}
2 changes: 1 addition & 1 deletion .storybook/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
background-color: castor.color('background-main');
color: castor.color('content-main');
font-family: 'Helvetica Neue', Tahoma, sans-serif;
font-size: 16px;
font-size: 1rem;
}

// unfortunate hack to override background color of the Docs panel
Expand Down
8 changes: 8 additions & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Migration guides

## 1.x to 2.x

### Select native (CSS) - React not impacted

- `.-empty` class on `.ods-select-native` should be now on `.ods-select` instead
- (NON-BREAKING) `.ods-select-native` no longer needs `.-borderless` class, only its parent `.ods-select` does
4 changes: 2 additions & 2 deletions docs/helpers/html.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ const content = (nodes: unknown[]) => nodes.filter(Boolean).join('\n');

function toAttribute([key, value]: [string, unknown]) {
if (key === 'style' && typeof value === 'object') value = styleFor(value);
if (value === '' || value === true) return key;
if (!value) return '';
if (value === true) return key;
if (value === false || value == null) return '';

return `${key}="${value}"`;
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
70 changes: 44 additions & 26 deletions packages/core/src/components/popover/popover.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,69 +12,87 @@
position: absolute;
visibility: hidden;
z-index: 9999999;

&.-overlay {
/* stylelint-disable-next-line max-nesting-depth */
&::before {
$inset: 0;

background-color: helpers.color('background-overlay');
bottom: $inset;
content: '';
display: block;
left: $inset;
position: fixed;
right: $inset;
top: $inset;
visibility: visible;
}

/* stylelint-disable-next-line max-nesting-depth */
.ods-popover {
bottom: initial;
height: fit-content;
left: 50%;
max-height: 75%;
max-width: 75%;
position: fixed;
right: initial;
top: 50%;
transform: translate(-50%, -50%);
width: fit-content;
}
}
}

.ods-popover {
height: fit-content;
max-width: helpers.space(50);
overflow: auto;
overscroll-behavior: contain;
position: absolute;
visibility: initial;
width: max-content;

// position ==========>
&.-top--center,
&.-top--start,
&.-top--end {
&:where(.-top--center, .-top--start, .-top--end) {
@include _position(bottom);
}

&.-bottom--center,
&.-bottom--start,
&.-bottom--end {
&:where(.-bottom--center, .-bottom--start, .-bottom--end) {
@include _position(top);
}

&.-left--center,
&.-left--start,
&.-left--end {
&:where(.-left--center, .-left--start, .-left--end) {
@include _position(right);
}

&.-right--center,
&.-right--start,
&.-right--end {
&:where(.-right--center, .-right--start, .-right--end) {
@include _position(left);
}
// <========== position

// alignment ==========>
&.-top--center,
&.-bottom--center {
&:where(.-top--center, .-bottom--center) {
@include _center(X);
}

&.-left--center,
&.-right--center {
&:where(.-left--center, .-right--center) {
@include _center(Y);
}

&.-top--start,
&.-bottom--start {
&:where(.-top--start, .-bottom--start) {
left: 0;
}

&.-left--start,
&.-right--start {
&:where(.-left--start, .-right--start) {
top: 0;
}

&.-top--end,
&.-bottom--end {
&:where(.-top--end, .-bottom--end) {
right: 0;
}

&.-left--end,
&.-right--end {
&:where(.-left--end, .-right--end) {
bottom: 0;
}
// <========== alignment
Expand All @@ -83,7 +101,7 @@

@mixin _position($side) {
#{$side}: 100%;
margin-#{$side}: helpers.space(1);
margin-#{$side}: var(--popover-gap, helpers.space(0.125));
}

@mixin _center($axis) {
Expand Down
Loading