Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard import placeholders #476

Merged
merged 8 commits into from
Feb 18, 2025
Merged

Use standard import placeholders #476

merged 8 commits into from
Feb 18, 2025

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Feb 11, 2025

Updates all the contracts, transactions and scripts to use the standard import placeholder format import "...." instead of the old format.

I know there are a lot to review, but the changes are exactly the same for every file, so it shouldn't take too long to review

The flow-evm bridge is now using the core contracts templates package to replace import placeholders and uses the current format, so this needs to be updated to support that.

I'll work on updating flow-go transaction as well.

Flag: Tests are failing because flow-go relies on the old package that replaces addresses based on the old format. To get tests to pass, we'll need a new version of the emulator with this change.

@joshuahannan
Copy link
Member Author

Once I get an approval on this, I will tag a pre-release based off this branch so I can update flow-go

Copy link
Collaborator

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked some files and it looks good to me, but I didn't go through everything. Please let me know if there are any files I need to specifically check.

@joshuahannan joshuahannan merged commit 9339cb6 into master Feb 18, 2025
2 checks passed
@joshuahannan joshuahannan deleted the templates-replace branch February 18, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants