-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CrossVM views #243
Add CrossVM views #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add examples of these to ExampleNFT
and add some tests?
Co-authored-by: Joshua Hannan <hannanjoshua19@gmail.com>
@joshuahannan I've added implementation into ExampleNFT and tests. lmk if you think those are sufficient. Cadence tests are passing locally, but CI is failing on the go tests. I think I'll have to get the EVM contract into the go test env as they're failing locally as well. We can also add more use case specific examples for Cadence- and EVM-native NFT collections once the bridge changes are complete. |
I've removed the original example view resolution in ExampleNFT which attempted to serialize using the Looks like CI is failing due to the changes in the ExampleNFT. When emulator is bootstrapped, it deploys tbh I'm surprised emulator includes a non-critical contract when setting up the environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this happens sometimes. We'll just need to tag a prerelease based on this branch and use that in flow-go, then when the emulator is updated, we can merge this.
We need to do that anyway with my core contracts PR. I'm sure there is a better way around this, but I don't know either.
Another option would be to add a separate contract getter to the |
Closes: #242
Related: onflow/flow-evm-bridge#164
Description
CrossVMMetadataViews
For contributor use:
master
branchFiles changed
in the Github PR explorer