fix(completion/#2264): Overflow in the UI (#2329)

Various UI fixes for the completion UI, including:
- Better handling of large font sizes
- Better handling of custom line heights (the height for suggestions was hardcoded previously; now it's in sync with the line height)
- The preview of the `detail` property from suggestion is inline with the completion item

This improves the look-and-feel of the completion UI, but there's still a few things I'd like to look at as next steps:
- Introducing a subtle enter/exit animation so it is not as 'jarring' when it pops open - help smooths out cases where it closes for a frame and comes back (ie, an incomplete completion provider)
- Add UX for the `documentation` property - this could show snippet or emmet expansions, or detailed documentation for properties. Need to experiment with the right experience here.

Fixes #2264

CHANGES_CURRENT.md

@@ -49,6 +49,7 @@
 - #3404 - UX - Explorer: Fix text overflow in explorer (fixes #3362)
 - #3414 - Code Actions: Fix regression in control-p binding
 - #3416 - Editor: Fix word-wrap calculation with tab characters (fixes #3372)
+- #2329 - UX - Completion: Fix overflowing detail text (fixes #2264)
 
 ### Performance
 

src/Feature/Editor/OverlaysView.re

@@ -27,6 +27,7 @@ let completionsView =
       ~buffer,
       ~cursor,
       ~languageSupport,
+      ~lineHeight,
       ~cursorPixelX,
       ~cursorPixelY,
       ~theme,
@@ -40,7 +41,7 @@ let completionsView =
         cursor
         x=cursorPixelX
         y=cursorPixelY
-        lineHeight={editorFont.measuredHeight}
+        lineHeight
         theme
         tokenTheme
         editorFont
@@ -101,12 +102,14 @@ let make =
 
   let cursorPixelY = pixelY |> int_of_float;
   let cursorPixelX = pixelX +. gutterWidth |> int_of_float;
+  let lineHeight = Editor.lineHeightInPixels(editor);
 
   isActiveSplit
     ? <View style=Styles.bufferViewOverlay>
         <completionsView
           cursor=cursorPosition
           buffer
+          lineHeight
           languageSupport
           cursorPixelX
           cursorPixelY