fix(completion/#2264): Overflow in the UI #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bryphe
added a commit
that referenced
this pull request
Feb 13, 2021
This adds the built in VSCode emmet extension (Emmet 2.0), and hooks it up. There are a few additional features we need, though, to get it usable: - [x] Handle the `isIncomplete` value from a completion provider - emmet sends this to tell the editor to continue to request completions. We don't handle it, currently. - [x] Proper snippet expansion - we have an extremely minimal snippet implementation, which means the expansion aren't too helpful __Next steps:__ - Completion documentation - there is no preview for the expansion, currently. (tracking in #2329 ) Fixes #1948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various UI fixes for the completion UI, including:
detailproperty from suggestion is inline with the completion itemThis improves the look-and-feel of the completion UI, but there's still a few things I'd like to look at as next steps:
documentationproperty - this could show snippet or emmet expansions, or detailed documentation for properties. Need to experiment with the right experience here.Fixes #2264