Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet support #1948

Closed
yunti opened this issue Jun 17, 2020 · 0 comments · Fixed by #2244
Closed

Emmet support #1948

yunti opened this issue Jun 17, 2020 · 0 comments · Fixed by #2244
Labels
A-extension Area: Extension/plugin integration, vscode or VimL enhancement New feature or request

Comments

@yunti
Copy link

yunti commented Jun 17, 2020 •
edited
Loading

It would be great to have Emmet support in onivim2 as it's amazing how much it's relied on when writing jsx or html. This is built in to vscode rather than a plugin, so I'm not sure how onivim would integrate it?

(as part of the integration, it would be great to have the wrap with abbreviation functionality which is a big improvement over vim surround's wrap with tag,
https://docs.emmet.io/actions/wrap-with-abbreviation/)
@bryphe bryphe added A-extension Area: Extension/plugin integration, vscode or VimL enhancement New feature or request labels Jun 18, 2020
This was referenced Aug 5, 2020
Merged
Open
@bryphe bryphe mentioned this issue Jan 21, 2021
Closed
bryphe added a commit that referenced this issue Feb 13, 2021
@bryphe
feat(extensions): Add emmet extension (#2244)
ad85033 
This adds the built in VSCode emmet extension (Emmet 2.0), and hooks it up.

There are a few additional features we need, though, to get it usable:
- [x] Handle the `isIncomplete` value from a completion provider - emmet sends this to tell the editor to continue to request completions. We don't handle it, currently. 
- [x] Proper snippet expansion - we have an extremely minimal snippet implementation, which means the expansion aren't too helpful

__Next steps:__
-  Completion documentation - there is no preview for the expansion, currently. (tracking in #2329 )

Fixes #1948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-extension Area: Extension/plugin integration, vscode or VimL enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(extensions): Add emmet extension onivim/oni2
2 participants
@yunti @bryphe