allow config of the vet flag for go test (#562)

* allow config of the vet flag for `go test` Signed-off-by: Topher Bullock <cbullock@pivotal.io>
onsi · Mar 7, 2019 · 3cd45fa · 3cd45fa
1 parent d56ee76
commit 3cd45fa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/ginkgo/run_watch_and_build_command_flags.go b/ginkgo/run_watch_and_build_command_flags.go
@@ -141,6 +141,7 @@ func (c *RunWatchAndBuildCommandFlags) flags(mode int) {
 	c.FlagSet.IntVar(c.intSlot("memprofilerate"), "memprofilerate", 0, "Enable more precise (and expensive) memory profiles by setting runtime.MemProfileRate.")
 	c.FlagSet.StringVar(c.stringSlot("outputdir"), "outputdir", "", "Place output files from profiling in the specified directory.")
 	c.FlagSet.BoolVar(c.boolSlot("requireSuite"), "requireSuite", false, "Fail if there are ginkgo tests in a directory but no test suite (missing RunSpecs)")
+	c.FlagSet.StringVar(c.stringSlot("vet"), "vet", "", "Configure the invocation of 'go vet' to use the comma-separated list of vet checks. If list is 'off', 'go test' does not run 'go vet' at all.")
 
 	if mode == runMode || mode == watchMode {
 		config.Flags(c.FlagSet, "", false)

diff --git a/ginkgo/testrunner/test_runner.go b/ginkgo/testrunner/test_runner.go
@@ -119,6 +119,7 @@ func (t *TestRunner) BuildArgs(path string) []string {
 		"coverpkg",
 		"tags",
 		"gcflags",
+		"vet",
 		"mod",
 	}
 

diff --git a/ginkgo/testrunner/test_runner_test.go b/ginkgo/testrunner/test_runner_test.go
@@ -32,6 +32,7 @@ var _ = Describe("TestRunner", func() {
 			"coverpkg":         strAddr(""),
 			"cover":            boolAddr(false),
 			"blockprofilerate": intAddr(100),
+			"vet":              strAddr("off"),
 			"mod":              strAddr("vendor"),
 		}
 		tr := testrunner.New(testsuite.TestSuite{}, 1, false, 0, opts, []string{})
@@ -51,6 +52,7 @@ var _ = Describe("TestRunner", func() {
 			"-asmflags=a",
 			"-pkgdir=b",
 			"-gcflags=c",
+			"-vet=off",
 			"-mod=vendor",
 		}))
 	})