Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow config of the vet flag for go test #562

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

topherbullock
Copy link
Contributor

This is useful when running ginkgo against go code built pre-1.11, when vet wasn't run by default by go test

Signed-off-by: Topher Bullock <cbullock@pivotal.io>
@williammartin
Copy link
Sponsor Collaborator

Can you add a test for this please. Something like:

diff --git a/ginkgo/testrunner/test_runner_test.go b/ginkgo/testrunner/test_runner_test.go
index 6919170..92f1c1f 100644
--- a/ginkgo/testrunner/test_runner_test.go
+++ b/ginkgo/testrunner/test_runner_test.go
@@ -32,6 +32,7 @@ var _ = Describe("TestRunner", func() {
      "coverpkg":         strAddr(""),
      "cover":            boolAddr(false),
      "blockprofilerate": intAddr(100),
+     "vet":              strAddr("off"),
    }
    tr := testrunner.New(testsuite.TestSuite{}, 1, false, 0, opts, []string{})

@@ -50,6 +51,7 @@ var _ = Describe("TestRunner", func() {
      "-asmflags=a",
      "-pkgdir=b",
      "-gcflags=c",
+     "-vet=off",
    }))
  })
 })

@williammartin
Copy link
Sponsor Collaborator

@topherbullock Can you please update this with tests?

@williammartin williammartin merged commit 3cd45fa into onsi:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants