-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When running against multiple packages, ginkgo --cover
should generate a composite coverfile and emit a single coverage percentage
#89
Comments
Additionally it could be configured to fail if coverage drops? |
ginkgo --cover
should generate a composite coverfile
ginkgo --cover
should generate a composite coverfileginkgo --cover
should generate a composite coverfile and emit a single coverage percentage
I would like to +1 this. I'm currently using gover to collect various |
+1 on doing it "right". But I'm not sure there is one right way... I write a lot of high-level functional test and often end up with tests at the top level that really test subpackages. The net effect is that I want coverprofiles to be merged and not just concatenated. The way I do that is my Makefile's cover rule has something like:
and the awk script to do the merging is:
I hope this helps... |
+1 |
+1 this would be pretty fantastic! |
If someone want's to point out the code which needs focus, I am happy to take a crack at it. Haven't looked at the codebase for this project yet. |
What is the status of this? Seems like it would be a nice feature. |
Yes!!!! Thanks :) - I hope to take a look and merge your PR tomorrow.
… On Jul 19, 2017, at 2:53 PM, Alexey Soshin ***@***.***> wrote:
@onsi I'm thinking of implementing this together with -outputdir, which doesn't work right now, and after PR #355 is merged. WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
No description provided.
The text was updated successfully, but these errors were encountered: