When running against multiple packages, ginkgo --cover should generate a composite coverfile and emit a single coverage percentage

[onsi]

No description provided.

[onsi]

Additionally it could be configured to fail if coverage drops?

[robdimsdale]

I would like to +1 this.

I'm currently using gover to collect various coverfiles in preparation for sending to a coverage processor (e.g. coveralls.io) and it would be an easier workflow if ginkgo collected them for me.

[tve]

+1 on doing it "right". But I'm not sure there is one right way... I write a lot of high-level functional test and often end up with tests at the top level that really test subpackages. The net effect is that I want coverprofiles to be merged and not just concatenated. The way I do that is my Makefile's cover rule has something like:

        @for f in `find . -name \*.coverprofile`; do tail -n +2 $$f >>_total; done
        @echo 'mode: atomic' >total.coverprofile
        @awk -f merge-profiles.awk <_total >>total.coverprofile

and the awk script to do the merging is:

#! /usr/bin/awk
BEGIN { FS = " " }
NF == 3 {
        k = $1 " " $2;
        if (k in block) block[k] += $3
        else block[k] = $3
}
END {
        for (k in block) {
                print k, block[k]
        }
}

I hope this helps...

[mantzas]

+1

[thedodd]

+1 this would be pretty fantastic!

[thedodd]

If someone want's to point out the code which needs focus, I am happy to take a crack at it. Haven't looked at the codebase for this project yet.

[johanbrandhorst]

What is the status of this? Seems like it would be a nice feature.

[AlexeySoshin]

@onsi I'm thinking of implementing this together with -outputdir, which doesn't work right now, and after PR #355 is merged. WDYT?

[onsi]

Yes!!!! Thanks :) - I hope to take a look and merge your PR tomorrow.

…

On Jul 19, 2017, at 2:53 PM, Alexey Soshin ***@***.***> wrote: @onsi I'm thinking of implementing this together with -outputdir, which doesn't work right now, and after PR #355 is merged. WDYT? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.