-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle -coverprofile flag #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AlexeySoshin take a look at my comment and let me know if you'll have the bandwidth to fix.
ginkgo/testrunner/test_runner.go
Outdated
@@ -473,7 +489,7 @@ func (t *TestRunner) run(cmd *exec.Cmd, completions chan RunResult) RunResult { | |||
func (t *TestRunner) combineCoverprofiles() { | |||
profiles := []string{} | |||
for cpu := 1; cpu <= t.numCPU; cpu++ { | |||
coverFile := fmt.Sprintf("%s.coverprofile.%d", t.Suite.PackageName, cpu) | |||
coverFile := fmt.Sprintf("%s%s.%d", t.Suite.PackageName, CoverProfileSuffix, cpu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works any more, no?
If you don't use the default name combineCoverprofiles
won't find the cover profile you asked for. have you tried running with ginkgo -p -coverprofile="foo"
to see it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onsi Done
sweet! LGTM! |
Fixes #346