Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle -outputdir flag #364

Merged
merged 14 commits into from
Jul 21, 2017
Merged

Handle -outputdir flag #364

merged 14 commits into from
Jul 21, 2017

Conversation

AlexeySoshin
Copy link
Contributor

@AlexeySoshin AlexeySoshin commented Jul 20, 2017 •
edited

Fixes #89

@AlexeySoshin AlexeySoshin changed the title Fix outputdir Handle -outputdir flag Jul 20, 2017
@AlexeySoshin AlexeySoshin changed the title Handle -outputdir flag [WIP] Handle -outputdir flag Jul 20, 2017
@AlexeySoshin AlexeySoshin changed the title [WIP] Handle -outputdir flag Handle -outputdir flag Jul 20, 2017
@onsi
Copy link
Owner

onsi commented Jul 21, 2017

I think this looks good @AlexeySoshin - can you fix up the conflicts and I'll merge this today?

@onsi
Copy link
Owner

onsi commented Jul 21, 2017

Also - do you mind submitting a PR to the gh-pages branch updating the documentation for the -cover related flags? The right section is under "Running the race detector and code coverage tools:"

Thanks!

@onsi onsi merged commit 228e3a8 into onsi:master Jul 21, 2017
@onsi
Copy link
Owner

onsi commented Jul 21, 2017

Great! You up for a docs PR?

@AlexeySoshin
Copy link
Contributor Author

@onsi Of course I am :)

@onsi
Copy link
Owner

onsi commented Jul 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexeySoshin @onsi