-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validated + reformatted dynamic beat acquisition #3006
Merged
Merged
+748
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
beat_robustification
branch
from
November 1, 2024 17:08
1407652
to
75cca9a
Compare
rkuo-danswer
requested changes
Nov 1, 2024
rkuo-danswer
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beat_schedule probably belongs outside of the tasks folder as it's really assocated with the app. Not a huge deal to change at the moment, can move it later as needed.
pablonyx
force-pushed
the
beat_robustification
branch
from
November 1, 2024 23:38
58c9f88
to
8ff8a88
Compare
* add validated + reformatted dynamic beat acquisition * initial removal of locks! * minor * remove unecessary locks * update * nit * k * K8s jobs (#3033) * add k8s configs * k * update config * k * improved timeouts + worker configs * improve workers
pablonyx
force-pushed
the
beat_robustification
branch
from
November 3, 2024 17:56
2b73a29
to
6395945
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 3, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.