Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validated + reformatted dynamic beat acquisition #3006

Merged
merged 9 commits into from
Nov 3, 2024

Conversation

pablonyx
Copy link
Contributor

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 6:00pm

backend/danswer/background/celery/apps/beat.py Outdated Show resolved Hide resolved
backend/danswer/background/celery/apps/beat.py Outdated Show resolved Hide resolved
backend/danswer/background/celery/apps/beat.py Outdated Show resolved Hide resolved
backend/danswer/background/celery/apps/beat.py Outdated Show resolved Hide resolved
backend/danswer/background/celery/apps/beat.py Outdated Show resolved Hide resolved
backend/danswer/background/celery/tasks/tasks.py Outdated Show resolved Hide resolved
@pablonyx pablonyx requested a review from rkuo-danswer November 1, 2024 19:07
@pablonyx pablonyx marked this pull request as ready for review November 1, 2024 19:34
Copy link
Contributor

@rkuo-danswer rkuo-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beat_schedule probably belongs outside of the tasks folder as it's really assocated with the app. Not a huge deal to change at the moment, can move it later as needed.

* add validated + reformatted dynamic beat acquisition

* initial removal of locks!

* minor

* remove unecessary locks

* update

* nit

* k

* K8s jobs (#3033)

* add k8s configs

* k

* update config

* k

* improved timeouts + worker configs

* improve workers
@pablonyx pablonyx force-pushed the beat_robustification branch from 2b73a29 to 6395945 Compare November 3, 2024 17:56
@pablonyx pablonyx added this pull request to the merge queue Nov 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 3, 2024
@pablonyx pablonyx merged commit 46e5ffa into main Nov 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants