Remove locks #3017
Merged
Remove locks #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
beat_robustification
branch
from
1407652 to
75cca9a
Compare
rkuo-danswer
requested changes
Nov 1, 2024
| break | ||
|
|
||
| time.monotonic() |
There was a problem hiding this comment.
This seems like a no op?
| @@ -75,7 +75,7 @@ def run_jobs() -> None: | |||
| cmd_beat = [ | |||
| "celery", | |||
| "-A", | |||
| "danswer.background.celery.versioned_apps.beat", | |||
| "danswer.background.celery.apps.beat", | |||
There was a problem hiding this comment.
we should still use the versioned apps stub for consistency, but just point it at the single beat app. Don't want someone to have to think about what entrypoint to use for the celery apps.
pablonyx
force-pushed
the
beat_robustification
branch
from
58c9f88 to
8ff8a88
Compare
trial-danswer
approved these changes
Nov 3, 2024
* add k8s configs * k * update config * k * improved timeouts + worker configs * improve workers
pablonyx
added a commit
that referenced
this pull request
Nov 3, 2024
* add validated + reformatted dynamic beat acquisition * initial removal of locks! * minor * remove unecessary locks * update * nit * k * K8s jobs (#3033) * add k8s configs * k * update config * k * improved timeouts + worker configs * improve workers
pablonyx
added a commit
that referenced
this pull request
Nov 3, 2024
* add validated + reformatted dynamic beat acquisition * validate * reorg * nit * address comments * update * typing * ensure versioned apps capture * Remove locks (#3017) * add validated + reformatted dynamic beat acquisition * initial removal of locks! * minor * remove unecessary locks * update * nit * k * K8s jobs (#3033) * add k8s configs * k * update config * k * improved timeouts + worker configs * improve workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.