make the agent deploy controller watch the managed cluster #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
watch-cluster
branch
3 times, most recently
from
10f5803
to
03db4ac
Compare
zhujian7
changed the title
|
/assign @qiujian16 @zhiweiyin318 |
qiujian16
reviewed
Aug 1, 2023
pkg/agent/inteface.go
Outdated
| // AgentDeployClusterInformerFilter: func(old, new *clusterv1.ManagedCluster) bool { | ||
| // return !equality.Semantic.DeepEqual(old.Annotations, new.Annotations) | ||
| // } | ||
| AgentDeployClusterInformerFilter func(old, new *clusterv1.ManagedCluster) bool |
There was a problem hiding this comment.
Suggested change
| AgentDeployClusterInformerFilter func(old, new *clusterv1.ManagedCluster) bool | |
| AgentDeployTriggerClusterFilter func(old, new *clusterv1.ManagedCluster) bool |
something like this?
pkg/agent/inteface.go
Outdated
| @@ -76,6 +76,19 @@ type AgentAddonOptions struct { | |||
| // SupportedConfigGVRs is a list of addon supported configuration GroupVersionResource | |||
| // each configuration GroupVersionResource should be unique | |||
| SupportedConfigGVRs []schema.GroupVersionResource | |||
|
|
|||
| // AgentDeployClusterInformerFilter defines the filter function for the cluster informer when deploying the addon | |||
There was a problem hiding this comment.
the filter func to trigger the agent deploy/redploy when cluster info is changed.
Signed-off-by: zhujian <jiazhu@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 822eeca
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an option for developer to make the agent deploy controller watches the managed cluster, so if there are any changes on the managed cluster, the agent deploy controller can reconcile quickly
for example: if a helm addon wants managed cluster annotation changing trigger the agent redeploy:
issue reference: #198