🌱 Add a helper func to check if a managed cluster condition changes #230
Conversation
|
/cc @qiujian16 |
pkg/utils/helpers.go
Outdated
| newAvailableCondition := meta.FindStatusCondition(new.Status.Conditions, conditionType) | ||
|
|
||
| return oldAvailableCondition != nil && newAvailableCondition != nil && | ||
| oldAvailableCondition.Status != newAvailableCondition.Status |
There was a problem hiding this comment.
what if both condition are nil? and do we need to compare observerdGeneration and lastTransittionTime
There was a problem hiding this comment.
if both are nil, it does not change.
if one is nil, but the other is not, it changes, I will handle this.
there is no observerdGenereation in the managed cluster, and we only care about the condition status, so I think condition.status is enough.
Signed-off-by: zhujian <jiazhu@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d2afcef
into
open-cluster-management-io:main
Add a helper func to check if a managed cluster condition changes, so users can use this to make the agent deploy controller watch if the managed cluster condition changes.
related PR: #199