✨ refactor setting the helm default variable of hostingClusterCapabilities #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
|
/hold |
| hostingCluster, err := a.clusterClient.ClusterV1().ManagedClusters(). | ||
| Get(context.TODO(), hostingClusterName, metav1.GetOptions{}) | ||
| if err != nil { | ||
| klog.Errorf("failed to get hostingCluster %s. err:%v", hostingClusterName, err) |
There was a problem hiding this comment.
should we ignore err if the hostingCluster is NotFound here ?
Signed-off-by: zhujian <jiazhu@redhat.com>
|
/lgtm |
mprahl
approved these changes
Mar 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zhujian7 can this be merged? |
|
/unhold |
openshift-merge-bot
bot
merged commit bffb77d
into
open-cluster-management-io:main
12 checks passed
|
/cherry-pick release-0.9 |
|
@xuezhaojun: #251 failed to apply on top of branch "release-0.9": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
xuezhaojun
pushed a commit
to xuezhaojun/addon-framework
that referenced
this pull request
May 28, 2024
…ities (open-cluster-management-io#251) * refactor setting the helm default variable of hostingClusterCapabilities Signed-off-by: zhujian <jiazhu@redhat.com> * add deprecated marks Signed-off-by: zhujian <jiazhu@redhat.com> * ignore not found error for getting hosting cluster Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
pushed a commit
to xuezhaojun/addon-framework
that referenced
this pull request
May 28, 2024
…ities (open-cluster-management-io#251) * refactor setting the helm default variable of hostingClusterCapabilities Signed-off-by: zhujian <jiazhu@redhat.com> * add deprecated marks Signed-off-by: zhujian <jiazhu@redhat.com> * ignore not found error for getting hosting cluster Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
May 29, 2024
…ities (#251) (#272) * refactor setting the helm default variable of hostingClusterCapabilities * add deprecated marks * ignore not found error for getting hosting cluster --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com> Co-authored-by: Jian Zhu <jiazhu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes ##246 (comment)