-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ refactor setting the helm default variable of hostingClusterCapabilities #251
✨ refactor setting the helm default variable of hostingClusterCapabilities #251
Conversation
Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
/hold |
hostingCluster, err := a.clusterClient.ClusterV1().ManagedClusters(). | ||
Get(context.TODO(), hostingClusterName, metav1.GetOptions{}) | ||
if err != nil { | ||
klog.Errorf("failed to get hostingCluster %s. err:%v", hostingClusterName, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we ignore err if the hostingCluster is NotFound here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Signed-off-by: zhujian <jiazhu@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zhujian7 can this be merged? |
/unhold |
bffb77d
into
open-cluster-management-io:main
/cherry-pick release-0.9 |
@xuezhaojun: #251 failed to apply on top of branch "release-0.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…ities (open-cluster-management-io#251) * refactor setting the helm default variable of hostingClusterCapabilities Signed-off-by: zhujian <jiazhu@redhat.com> * add deprecated marks Signed-off-by: zhujian <jiazhu@redhat.com> * ignore not found error for getting hosting cluster Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com>
…ities (open-cluster-management-io#251) * refactor setting the helm default variable of hostingClusterCapabilities Signed-off-by: zhujian <jiazhu@redhat.com> * add deprecated marks Signed-off-by: zhujian <jiazhu@redhat.com> * ignore not found error for getting hosting cluster Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com>
…ities (#251) (#272) * refactor setting the helm default variable of hostingClusterCapabilities * add deprecated marks * ignore not found error for getting hosting cluster --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com> Co-authored-by: Jian Zhu <jiazhu@redhat.com>
Summary
Related issue(s)
Fixes ##246 (comment)