Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ refactor setting the helm default variable of hostingClust… #272

Conversation

xuezhaojun
Copy link
Member

…erCapabilities (#251)

  • refactor setting the helm default variable of hostingClusterCapabilities
  • add deprecated marks
  • ignore not found error for getting hosting cluster

Summary

Related issue(s)

Fixes #

@xuezhaojun
Copy link
Member Author

/assign @zhujian7
/assign @qiujian16

…ities (open-cluster-management-io#251)

* refactor setting the helm default variable of hostingClusterCapabilities

Signed-off-by: zhujian <jiazhu@redhat.com>

* add deprecated marks

Signed-off-by: zhujian <jiazhu@redhat.com>

* ignore not found error for getting hosting cluster

Signed-off-by: zhujian <jiazhu@redhat.com>

---------

Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: xuezhaojun <zxue@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cee1ae4 into open-cluster-management-io:release-0.9 May 29, 2024
9 checks passed
@xuezhaojun xuezhaojun deleted the cherry-pick-hostingClusterCapabilities branch May 29, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants