-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix: add a condition of manifestapplied for hosted addon. #267
🐛 Fix: add a condition of manifestapplied for hosted addon. #267
Conversation
Signed-off-by: xuezhaojun <zxue@redhat.com>
TODO: The fix need to be cherry-pick to release 0.9.3. |
/assign @qiujian16 |
/cherry-pick release-0.9 |
@qiujian16: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
286f8d0
into
open-cluster-management-io:main
@qiujian16: #267 failed to apply on top of branch "release-0.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…er-management-io#267) Signed-off-by: xuezhaojun <zxue@redhat.com>
Summary
For hosted mode addons, there are no manifestwork need to be applied by default addondeploycontroller, we want to add a condition to state that.