The addonProcessController should consider the hosting case.

[xuezhaojun]

Describe the bug

There are mainly 2 place not considering the hosted mode in the addonProcessController:

1

https://github.com/stolostron/ocm/blob/6430b333e7f19c9faeab78c1e6aa41f9b4d64c26/pkg/addon/controllers/addonprogressing/controller.go#L135

The controller will wait for ManagedClusterAddOnManifestApplied but for hosted mode, there will only be a HostingManifestApplied .

As a result the there will always be Waiting condition for the addon.

2

https://github.com/stolostron/ocm/blob/6430b333e7f19c9faeab78c1e6aa41f9b4d64c26/pkg/addon/controllers/addonprogressing/controller.go#L155

From the comment we can see there is a TODO to consider hosted manifestwork.

The hosted addon will always show "no addon works" and hang in Processing is true state: https://github.com/stolostron/ocm/blob/6430b333e7f19c9faeab78c1e6aa41f9b4d64c26/pkg/addon/controllers/addonprogressing/controller.go#L165

[qiujian16]

@zhujian7 I think we have fixed this?

[zhujian7]

yes, #464

[xuezhaojun]

add addon-framework PR open-cluster-management-io/addon-framework#267

[xuezhaojun]

/close

[openshift-ci]

@xuezhaojun: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.