Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handle hosted mode addons in addon progressing controller #464

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented May 15, 2024

Summary

Related issue(s)

Fixes #461

@openshift-ci openshift-ci bot requested review from elgnay and zhiweiyin318 May 15, 2024 09:34
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 62.72%. Comparing base (319d9af) to head (e0d00f8).

Files Patch % Lines
...g/addon/controllers/addonprogressing/controller.go 72.97% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   62.64%   62.72%   +0.08%     
==========================================
  Files         136      136              
  Lines       11529    11558      +29     
==========================================
+ Hits         7222     7250      +28     
- Misses       3539     3540       +1     
  Partials      768      768              
Flag Coverage Δ
unit 62.72% <73.68%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 force-pushed the addon-progressing branch from 54ce3fd to 5a10b83 Compare May 15, 2024 15:05
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 force-pushed the addon-progressing branch from 5a10b83 to e0d00f8 Compare May 15, 2024 15:07
@zhujian7 zhujian7 changed the title Handle hosted mode addons in addon progressing controller 🐛 Handle hosted mode addons in addon progressing controller May 15, 2024
@zhujian7
Copy link
Member Author

/cc @haoqing0110 @qiujian16 @xuezhaojun

@haoqing0110
Copy link
Member

LGTM

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit df3b290 into open-cluster-management-io:main May 16, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The addonProcessController should consider the hosting case.
3 participants