-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support addon health probe for checking workload availability #275
✨ Support addon health probe for checking workload availability #275
Conversation
55c2594
to
5093771
Compare
/hold |
96a3a24
to
3a43edd
Compare
/cc @qiujian16 |
/cc @zhiweiyin318 |
return nil | ||
} | ||
case "daemonsets": | ||
if readyReplicas == desiredNumberReplicas && readyReplicas > -1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiujian16 @zhiweiyin318 Do you think this is reasonable for daemonsets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a cluster has no nodes, when deploying a daemonset, it will be like:
╰─$ oc get ds nginx-deployment
NAME DESIRED CURRENT READY UP-TO-DATE AVAILABLE NODE SELECTOR AGE
nginx-deployment 0 0 0 0 0 <none> 18s
should we treat it as health or not?
as the current implementation, because the readyReplicas(0) == desiredNumberReplicas(0)
, it is health.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be healthy in this case.
Signed-off-by: zhujian <jiazhu@redhat.com>
3a43edd
to
40ee059
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/lgtm |
/unhold |
660e21b
into
open-cluster-management-io:main
…-cluster-management-io#275) Signed-off-by: zhujian <jiazhu@redhat.com>
Summary
Add a new health check probe type
WorkloadAvailability
to check if all deployments and daemonsets are available.Related issue(s)
open-cluster-management-io/ocm#368
Fixes #