chore: update part of the work api ReadOnly comment to clarify it's s…

…till possible to use status feedback (#338) Signed-off-by: Mike Ng <ming@redhat.com>
open-cluster-management-io · Jun 27, 2024 · bd6f222 · bd6f222
1 parent 05dd01d
commit bd6f222
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/addon/v1alpha1/0000_03_addon.open-cluster-management.io_addontemplates.crd.yaml b/addon/v1alpha1/0000_03_addon.open-cluster-management.io_addontemplates.crd.yaml
@@ -276,7 +276,8 @@ spec:
                                 ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
                                 If there is conflict, the related Applied condition of manifest will be in the status of False with the
                                 reason of ApplyConflict.
-                                ReadOnly type means the agent will only check the existence of the resource based on its metadata.
+                                ReadOnly type means the agent will only check the existence of the resource based on its metadata,
+                                statusFeedBackRules can still be used to get feedbackResults.
                               enum:
                               - Update
                               - CreateOnly

diff --git a/work/v1/0000_00_work.open-cluster-management.io_manifestworks.crd.yaml b/work/v1/0000_00_work.open-cluster-management.io_manifestworks.crd.yaml
@@ -259,7 +259,8 @@ spec:
                             ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
                             If there is conflict, the related Applied condition of manifest will be in the status of False with the
                             reason of ApplyConflict.
-                            ReadOnly type means the agent will only check the existence of the resource based on its metadata.
+                            ReadOnly type means the agent will only check the existence of the resource based on its metadata,
+                            statusFeedBackRules can still be used to get feedbackResults.
                           enum:
                           - Update
                           - CreateOnly

diff --git a/work/v1/types.go b/work/v1/types.go
@@ -162,7 +162,8 @@ type UpdateStrategy struct {
 	// ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
 	// If there is conflict, the related Applied condition of manifest will be in the status of False with the
 	// reason of ApplyConflict.
-	// ReadOnly type means the agent will only check the existence of the resource based on its metadata.
+	// ReadOnly type means the agent will only check the existence of the resource based on its metadata,
+	// statusFeedBackRules can still be used to get feedbackResults.
 	// +kubebuilder:default=Update
 	// +kubebuilder:validation:Enum=Update;CreateOnly;ServerSideApply;ReadOnly
 	// +kubebuilder:validation:Required

diff --git a/work/v1/zz_generated.swagger_doc_generated.go b/work/v1/zz_generated.swagger_doc_generated.go
diff --git a/work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml b/work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml
@@ -283,7 +283,8 @@ spec:
                                 ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
                                 If there is conflict, the related Applied condition of manifest will be in the status of False with the
                                 reason of ApplyConflict.
-                                ReadOnly type means the agent will only check the existence of the resource based on its metadata.
+                                ReadOnly type means the agent will only check the existence of the resource based on its metadata,
+                                statusFeedBackRules can still be used to get feedbackResults.
                               enum:
                               - Update
                               - CreateOnly