Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 chore: update part of the work api ReadOnly comment to clarify it's still possible to use status feedback #338

Conversation

mikeshng
Copy link
Member

Summary

I've gotten a question from a developer about ReadOnly. It seems like this part of the comment is not too clear because it states it will "only" check the existence but that's not totally true because status feedback can still be used.

Related issue(s)

Fixes #

…till possible to use status feedback

Signed-off-by: Mike Ng <ming@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 June 27, 2024 14:43
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bd6f222 into open-cluster-management-io:main Jun 27, 2024
10 checks passed
@mikeshng mikeshng deleted the update-work-comment branch June 27, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants