update the ClustersPerDecisionGroup explanation #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
haoqing0110
commented
Jul 18, 2023
•
haoqing0110
commented
- update the ClustersPerDecisionGroup explanation
- add validation for ClustersPerDecisionGroup, 0 and 0% is not allowed.
Signed-off-by: haoqing0110 <qhao@redhat.com>
|
/assign @qiujian16 @serngawy |
serngawy
approved these changes
Jul 18, 2023
qiujian16
reviewed
Jul 18, 2023
cluster/v1beta1/types_placement.go
Outdated
| @@ -126,8 +126,15 @@ type GroupStrategy struct { | |||
| // The percentage will divide the placementDecisions to decisionGroups each group has max number of clusters based on the total num of selected clusters and percentage. | |||
| // ex; for a total 100 clusters selected, ClustersPerDecisionGroup equal to 20% will divide the placement decision to 5 groups each group should have 20 clusters. | |||
| // Default is having all clusters in a single group. | |||
| // If the DecisionGroups field defined, it will be considered first to create the decisionGroups then the ClustersPerDecisionGroup will be used to determine the rest of decisionGroups. | |||
| // | |||
| // If the DecisionGroups field defined, it will be considered first to create the decisionGroups. The remaining of clusters will then be divided to decisionGroups based on ClustersPerDecisionGroup. | |||
There was a problem hiding this comment.
Suggested change
| // If the DecisionGroups field defined, it will be considered first to create the decisionGroups. The remaining of clusters will then be divided to decisionGroups based on ClustersPerDecisionGroup. | |
| // Decision groups will be constructed based on the DecisionGroups field at first. The clusters not included in the DecisionGroups will be divided to other decision groups afterwards. Each decision group should not have the number of clusters larger than the ClustersPerDecisionGroup. |
There was a problem hiding this comment.
I think this doc should be put on groupStrategy field rather than here. for ClustersPerDecisionGroup, we just need to doc that it is the max number of clusters a group should have.
There was a problem hiding this comment.
Moved this part to groupStrategy field.
Co-authored-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_placement-decision
branch
from
ece053a
to
79cccf0
Compare
Closed
serngawy
approved these changes
Jul 19, 2023
|
sound good to me |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16, serngawy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 0336f23
into
open-cluster-management-io:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.