-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the ClustersPerDecisionGroup explanation #253
update the ClustersPerDecisionGroup explanation #253
Conversation
haoqing0110
commented
Jul 18, 2023
•
edited
Loading
edited
- update the ClustersPerDecisionGroup explanation
- add validation for ClustersPerDecisionGroup, 0 and 0% is not allowed.
Signed-off-by: haoqing0110 <qhao@redhat.com>
/assign @qiujian16 @serngawy |
cluster/v1beta1/types_placement.go
Outdated
@@ -126,8 +126,15 @@ type GroupStrategy struct { | |||
// The percentage will divide the placementDecisions to decisionGroups each group has max number of clusters based on the total num of selected clusters and percentage. | |||
// ex; for a total 100 clusters selected, ClustersPerDecisionGroup equal to 20% will divide the placement decision to 5 groups each group should have 20 clusters. | |||
// Default is having all clusters in a single group. | |||
// If the DecisionGroups field defined, it will be considered first to create the decisionGroups then the ClustersPerDecisionGroup will be used to determine the rest of decisionGroups. | |||
// | |||
// If the DecisionGroups field defined, it will be considered first to create the decisionGroups. The remaining of clusters will then be divided to decisionGroups based on ClustersPerDecisionGroup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// If the DecisionGroups field defined, it will be considered first to create the decisionGroups. The remaining of clusters will then be divided to decisionGroups based on ClustersPerDecisionGroup. | |
// Decision groups will be constructed based on the DecisionGroups field at first. The clusters not included in the DecisionGroups will be divided to other decision groups afterwards. Each decision group should not have the number of clusters larger than the ClustersPerDecisionGroup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doc should be put on groupStrategy field rather than here. for ClustersPerDecisionGroup, we just need to doc that it is the max number of clusters a group should have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this part to groupStrategy field.
Co-authored-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com>
ece053a
to
79cccf0
Compare
sound good to me |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16, serngawy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0336f23
into
open-cluster-management-io:main