Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 divide pre-defined decision groups by length #227

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Jul 20, 2023

Summary

Related issue(s)

Follow-up of open-cluster-management-io/api#253

@openshift-ci openshift-ci bot requested review from elgnay and zhujian7 July 20, 2023 08:27
@haoqing0110 haoqing0110 force-pushed the br_placement-cluster-per-group branch from cb624cf to 6e909db Compare July 20, 2023 08:33
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 86.27% and project coverage change: +0.01 🎉

Comparison is base (8d974c2) 60.22% compared to head (abe0a94) 60.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   60.22%   60.24%   +0.01%     
==========================================
  Files         130      130              
  Lines       13502    13515      +13     
==========================================
+ Hits         8132     8142      +10     
- Misses       4619     4621       +2     
- Partials      751      752       +1     
Flag Coverage Δ
unit 60.24% <86.27%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/controllers/scheduling/scheduling_controller.go 67.03% <86.27%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: haoqing0110 <qhao@redhat.com>
@haoqing0110 haoqing0110 force-pushed the br_placement-cluster-per-group branch from 6e909db to abe0a94 Compare July 20, 2023 08:51
@haoqing0110
Copy link
Member Author

/assign @qiujian16

@haoqing0110 haoqing0110 changed the title divide pre-defined decision groups by length 🌱 divide pre-defined decision groups by length Jul 20, 2023
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5c03624 into open-cluster-management-io:main Jul 21, 2023
@haoqing0110 haoqing0110 deleted the br_placement-cluster-per-group branch July 21, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants