-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 remove ClusterSet ClusterSetBinding API version v1beta1 #266
🌱 remove ClusterSet ClusterSetBinding API version v1beta1 #266
Conversation
801d7e6
to
5751c6d
Compare
/hold |
Signed-off-by: haoqing0110 <qhao@redhat.com>
5751c6d
to
921a7ce
Compare
b873cce
to
921a7ce
Compare
/lgtm |
/approve |
/unhold |
/hold |
/unhold |
/assign @qiujian16 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, ldpliu, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9675ab7
into
open-cluster-management-io:main
…-cluster-management-io#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com>
…-cluster-management-io#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com>
…-cluster-management-io#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com>
…-cluster-management-io#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com>
Signed-off-by: melserngawy <melserng@redhat.com> Fix: run `make update` fail because deepcopy doesn't support generic type. (open-cluster-management-io#288) Signed-off-by: xuezhaojun <zxue@redhat.com> Fix verify ci step missing. (open-cluster-management-io#289) Signed-off-by: xuezhaojun <zxue@redhat.com> :bug: Use controller-runtime for deepcopy generation for cluster:v1alpha1 (open-cluster-management-io#291) * Revert "Fix: run `make update` fail because deepcopy doesn't support generic type. (open-cluster-management-io#288)" This reverts commit ae208c8. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> * Use `controller-gen` for deepcopy cluster:v1alpha1 GenGo isn't respecting the `+k8s:deepcopy-gen=false` tag to skip generation for the generic type Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> --------- Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> 🐛 add ca bundle to addon proxy settings (open-cluster-management-io#293) Signed-off-by: Yang Le <yangle@redhat.com> Revert "remove ClusterSet ClusterSetBinding API version v1beta1 (open-cluster-management-io#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com>
…-cluster-management-io#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com>
Fix: run `make update` fail because deepcopy doesn't support generic type. (#288) Fix verify ci step missing. (#289) :bug: Use controller-runtime for deepcopy generation for cluster:v1alpha1 (#291) * Revert "Fix: run `make update` fail because deepcopy doesn't support generic type. (#288)" This reverts commit ae208c8. * Use `controller-gen` for deepcopy cluster:v1alpha1 GenGo isn't respecting the `+k8s:deepcopy-gen=false` tag to skip generation for the generic type --------- 🐛 add ca bundle to addon proxy settings (#293) Revert "remove ClusterSet ClusterSetBinding API version v1beta1 (#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com> Co-authored-by: Mohamed ElSerngawy <melserng@redhat.com>
Summary
open-cluster-management-io/ocm#67
Related issue(s)
Fixes #