-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use controller-runtime for deepcopy generation for cluster:v1alpha1 #291
🐛 Use controller-runtime for deepcopy generation for cluster:v1alpha1 #291
Conversation
…generic type. (open-cluster-management-io#288)" This reverts commit ae208c8. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
1bc0888
to
817eca9
Compare
817eca9
to
6e77243
Compare
/lgtm |
/assign @qiujian16 |
@dhaiducek The bot may squash commits after merging the PR, and also, we may be able to replace deepcopy-gen with controller-gen entirely so that there is no exception in the makefile flow. |
Good point--I'll create a separate PR for the other updates. |
6e77243
to
246c492
Compare
I've split out the architecture updates into a new PR: |
I'm working on implementing a api/cluster/v1beta1/helpers.go Line 217 in d7736a1
|
For now, this PR might be the easiest path forward given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuezhaojun will this impact the make verify
?
No, from the code, Line 6 in d7736a1
|
GenGo isn't respecting the `+k8s:deepcopy-gen=false` tag to skip generation for the generic type Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
246c492
to
baf4645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2b7f212
into
open-cluster-management-io:main
…open-cluster-management-io#291) * Revert "Fix: run `make update` fail because deepcopy doesn't support generic type. (open-cluster-management-io#288)" This reverts commit ae208c8. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> * Use `controller-gen` for deepcopy cluster:v1alpha1 GenGo isn't respecting the `+k8s:deepcopy-gen=false` tag to skip generation for the generic type Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> --------- Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
…open-cluster-management-io#291) * Revert "Fix: run `make update` fail because deepcopy doesn't support generic type. (open-cluster-management-io#288)" This reverts commit ae208c8. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> * Use `controller-gen` for deepcopy cluster:v1alpha1 GenGo isn't respecting the `+k8s:deepcopy-gen=false` tag to skip generation for the generic type Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> --------- Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: melserngawy <melserng@redhat.com> Fix: run `make update` fail because deepcopy doesn't support generic type. (open-cluster-management-io#288) Signed-off-by: xuezhaojun <zxue@redhat.com> Fix verify ci step missing. (open-cluster-management-io#289) Signed-off-by: xuezhaojun <zxue@redhat.com> :bug: Use controller-runtime for deepcopy generation for cluster:v1alpha1 (open-cluster-management-io#291) * Revert "Fix: run `make update` fail because deepcopy doesn't support generic type. (open-cluster-management-io#288)" This reverts commit ae208c8. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> * Use `controller-gen` for deepcopy cluster:v1alpha1 GenGo isn't respecting the `+k8s:deepcopy-gen=false` tag to skip generation for the generic type Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> --------- Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> 🐛 add ca bundle to addon proxy settings (open-cluster-management-io#293) Signed-off-by: Yang Le <yangle@redhat.com> Revert "remove ClusterSet ClusterSetBinding API version v1beta1 (open-cluster-management-io#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com>
Fix: run `make update` fail because deepcopy doesn't support generic type. (#288) Fix verify ci step missing. (#289) :bug: Use controller-runtime for deepcopy generation for cluster:v1alpha1 (#291) * Revert "Fix: run `make update` fail because deepcopy doesn't support generic type. (#288)" This reverts commit ae208c8. * Use `controller-gen` for deepcopy cluster:v1alpha1 GenGo isn't respecting the `+k8s:deepcopy-gen=false` tag to skip generation for the generic type --------- 🐛 add ca bundle to addon proxy settings (#293) Revert "remove ClusterSet ClusterSetBinding API version v1beta1 (#266)" This reverts commit 9675ab7. Signed-off-by: haoqing0110 <qhao@redhat.com> Co-authored-by: Mohamed ElSerngawy <melserng@redhat.com>
Summary
GenGo doesn't seem to respect the
+k8s:deepcopy-gen:false
tag, so this is an alternative to #288, wherecontroller-gen
is used forcluster:v1alpha1
deepcopy generation rather than selective deepcopy generation.Related issue(s)
Followup to (and reverts):
make update
fail because deepcopy doesn't support generic … #288