✨ Add flag to allow use best effort resource for klusterlet #297
Conversation
|
/assign @qiujian16 |
|
would need to run |
operator/v1/types_klusterlet.go
Outdated
|
|
||
| // BestEffortResource allow use the best effort resource for operator/registration/work deployment | ||
| // +optional | ||
| BestEffortResource bool `json:"bestEffortResource,omitempty"` |
There was a problem hiding this comment.
It is better no to use boolean in API. You might consider a resources struct with a type in it. We can just set type to "BestEffort" and "Default" today, and add other option to be able to specify resource in the future.
There was a problem hiding this comment.
@qiujian16 thanks. address your comments and PTAL again.
|
|
||
| const ( | ||
| ResourceQosClassDefault ResourceQosClass = "Default" | ||
| ResourceQosClassBestEffort ResourceQosClass = "BestEffort" |
There was a problem hiding this comment.
some comments maybe to indicate what besteffort means
|
need to signoff. And you would need to run make update again. |
|
/ok-to-test |
|
@haowells: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all |
|
@haowells: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haowells, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: haolin <haowells@gmail.com>
|
/lgtm |
openshift-merge-bot
bot
merged commit 8814013
into
open-cluster-management-io:main
Summary
see PR in open-cluster-management-io/ocm#317
Related issue(s)
Fixes #