✨ klusterlet cr add flag to use best effort resources #317
Conversation
|
@qiujian16 PTAL. |
haowells
changed the title
haowells
changed the title
|
need to signoff the commit by |
| @@ -146,6 +146,8 @@ type klusterletConfig struct { | |||
| WorkFeatureGates []string | |||
|
|
|||
| HubApiServerHostAlias *operatorapiv1.HubApiServerHostAlias | |||
|
|
|||
There was a problem hiding this comment.
might worth adding a comment to indicate the meaning of this flag.
There was a problem hiding this comment.
@qiujian16 added the comments of flag meaning. so I need to start another PR to api repo?
There was a problem hiding this comment.
PR in api repo open-cluster-management-io/api#297 PTAL
There was a problem hiding this comment.
add @haoqing0110 PTAL
|
/approve looks good in general, just a minor comment and need to signoff the commit. Thanks! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 61.78% 61.76% -0.02%
==========================================
Files 132 132
Lines 13983 13989 +6
==========================================
+ Hits 8640 8641 +1
- Misses 4578 4583 +5
Partials 765 765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haowells
force-pushed
the
main
branch
2 times, most recently
from
4866432 to
dbb3520
Compare
|
LGTM |
|
/test all |
|
@haowells: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
try close/reopen PR trigger the pending job |
|
/ok-to-test |
|
/test all |
|
@haoqing0110: No presubmit jobs available for open-cluster-management-io/ocm@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: haolin <haowells@gmail.com>
Signed-off-by: haolin <haowells@gmail.com>
Signed-off-by: haolin <haowells@gmail.com>
|
needs to run |
|
/ok-to-test |
| @@ -118,10 +118,12 @@ spec: | |||
| scheme: HTTPS | |||
| port: 8443 | |||
| initialDelaySeconds: 2 | |||
| {{if ne .ResourceRequirements "BestEffort"}} | |||
There was a problem hiding this comment.
Seems a typo, should be ResourceRequirement, no s.
There was a problem hiding this comment.
thanks @haoqing0110 . typo fixed
Signed-off-by: haolin <haowells@gmail.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haowells, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 8a4c834
into
open-cluster-management-io:main
Summary
Klusterlet cr add new flag UseBestEffortResource which allow user use besteffort setting for deployment agent, registration, work etc
Related issue(s)
if resource quota setup in namespace, pod failed to startup and complain this error
Warning FailedCreate 7s (x3 over 14s) replicaset-controller (combined from similar events): Error creating: pods "klusterlet-registration-agent-7d777c4bff-hhxn6" is forbidden: failed quota: high-qos-limit-requests: must specify limits.cpu,limits.memoryFixes #